[SQL] Incorrect login_summary_statistics table name in LORIS 27 SQL patch - main #10097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongtiaowang
changed the title
Contributor
|
Fixes #10095 Thanks for the PR Shen! Can you also update all the places the table name appears in the documentation like in the linked issue ? |
Contributor
Author
|
@MaximeBICMTL The folder name "SQL/Login_Summary_Statistics" in the document follows the existing SQL-based naming convention accurately and aligns well with the actual content. Since the use of uppercase letters is consistent with other SQL directories and helps maintain clarity and uniformity across the project, no modification is necessary at this time. What do u think? |
MaximeBICMTL
approved these changes
Nov 11, 2025
Contributor
MaximeBICMTL
left a comment
MaximeBICMTL
left a comment
There was a problem hiding this comment.
Oh, I actually had not even noticed that these mentions were a directory and not the table name itself, thanks for pointing it out. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect login_summary_statistics table name in LORIS 27 SQL patch #10095