-
Notifications
You must be signed in to change notification settings - Fork 134
[ADD] dicom loader #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[ADD] dicom loader #366
Conversation
|
works with examples, not sure how to load 3rd party files, eg. clicking view own files UPDATE Actually, nifti does not open too, that bugs looks unrelated to DICOM |
MontrealSergiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dicom is rendered
| * BrainBrowser: Web-based Neurological Visualization Tools | ||
| * (https://brainbrowser.cbrain.mcgill.ca) | ||
| * | ||
| * Copyright (C) 2011-2014 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2011-2025?
| * - https://dicom.nema.org/medical/dicom/current/output/html/part03.html#sect_10.27.1 | ||
| */ | ||
|
|
||
| (function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what the purpose of bracket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MontrealSergiy If you mean the initial open parenthesis, this is a common way in javascript to execute code without creating any variable or references outside of it. If you look at the very bottom of the file you will see this:
)();
Let me give you an example with Ruby lambdas.
- Let's define a function and run it:
x = lambda { puts "Hello" }
x.()- Now the problem with the code above is that we have set a variable x. Maybe we don't want to pollute the current runtime binding with a variable like that. So given that an assigment also returns the value, we can just run it right there:
(x = lambda { puts "Hello" }).()- and since the variable is not needed:
(lambda { puts "Hello" }).()Javascript programmer do this because (at least in the traditional javascript) there are no namespaces in the language (no classes or modules) except for the namespace provided within a function. So to isolate all internal function names and variables and constants, they create an anonymous function and run it once.
Most javascript modules that want to be completely isolated are written as
(function() {
code;
function();
code;
})();|
This pull request should not include megabytes of DICOM files. In fact, in general a github repo is for CODE only. Datafiles should be fetched from external sources. |
prioux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all data files.
Add Dicom loader based on other BrainBrowser loader, and Papaya, and use Daikon lib