feat: audit follow up #1218

fusmanii · 2025-12-12T02:21:47Z

Added support for:

any token -> PERP, not just -> SPOT
account creation on the fly from user funds

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

…isal/perp-destination-dex

contracts/libraries/HyperCoreLib.sol

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

contracts/periphery/mintburn/HyperCoreFlowExecutor.sol

contracts/handlers/HyperliquidDepositHandler.sol

contracts/libraries/HyperCoreLib.sol

contracts/periphery/mintburn/sponsored-oft/ComposeMsgCodec.sol

contracts/periphery/mintburn/HyperCoreFlowExecutor.sol

contracts/periphery/mintburn/SwapHandler.sol

contracts/periphery/mintburn/sponsored-oft/ComposeMsgCodec.sol

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

* plan out the code Signed-off-by: Ihor Farion <ihor@umaproject.org> * dst side impl Signed-off-by: Ihor Farion <ihor@umaproject.org> * remove redundant var Signed-off-by: Ihor Farion <ihor@umaproject.org> * add account creation mode to encoded / decoded data Signed-off-by: Ihor Farion <ihor@umaproject.org> * fix tests and build Signed-off-by: Ihor Farion <ihor@umaproject.org> --------- Signed-off-by: Ihor Farion <ihor@umaproject.org>

Signed-off-by: Ihor Farion <ihor@umaproject.org>

contracts/periphery/mintburn/sponsored-oft/ComposeMsgCodec.sol

contracts/libraries/SponsoredCCTPQuoteLib.sol

Reinis-FRP · 2025-12-17T09:43:52Z

contracts/periphery/mintburn/HyperCoreFlowExecutor.sol

+        uint64 accountActivationFeeCore;
+        if (!userAccountExists) {
+            if (params.accountCreationMode == AccountCreationMode.Standard) {
+                if (!HyperCoreLib.coreUserExists(params.finalRecipient)) {


why repeated call and userAccountExists=false in this branch already

Oh, great call, thank you!

For standard mode, I just copied the existing logic and didn't update it based on the new outter if I added. Fixed in 2e5bb7e

Reinis-FRP · 2025-12-17T09:48:22Z

contracts/periphery/mintburn/HyperCoreFlowExecutor.sol

+        bool userAccountExists = HyperCoreLib.coreUserExists(params.finalRecipient);
+        if (!userAccountExists) {
+            if (params.accountCreationMode == AccountCreationMode.Standard) {
+                if (!HyperCoreLib.coreUserExists(params.finalRecipient)) {


userAccountExists=false in this branch already

contracts/interfaces/SponsoredCCTPInterface.sol

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Signed-off-by: Ihor Farion <ihor@umaproject.org>

contracts/periphery/mintburn/HyperCoreFlowExecutor.sol

Signed-off-by: Ihor Farion <ihor@umaproject.org>

tbwebb22 · 2025-12-18T21:57:49Z

contracts/periphery/mintburn/HyperCoreFlowExecutor.sol

+        bool userAccountExists = HyperCoreLib.coreUserExists(params.finalRecipient);
+        if (!userAccountExists) {
+            if (params.accountCreationMode == AccountCreationMode.Standard) {
+                if (params.maxBpsToSponsor > 0) {
+                    revert AccountNotActivatedError(params.finalRecipient);
+                } else {
+                    emit AccountNotActivated(params.quoteNonce, params.finalRecipient);
+                    params.finalToken = initialToken;
+                    _fallbackHyperEVMFlow(params);
+                    return;
+                }
+            } else {
+                // In the FromUserFunds logic for the swap flow, we only allow account creation if the final token is
+                // usable for it. Finilazing the swap flow should handle account creation automatically when doing the
+                // final transfer of tokens to the user
+                if (!finalCoreTokenInfo.canBeUsedForAccountActivation) {
+                    emit AccountNotActivated(params.quoteNonce, params.finalRecipient);
+                    params.finalToken = initialToken;
+                    _fallbackHyperEVMFlow(params);
+                    return;
+                }
+            }
+        }


also this could be simplified to something like:

if (!HyperCoreLib.coreUserExists(params.finalRecipient)) { bool isStandard = params.accountCreationMode == AccountCreationMode.Standard; if (isStandard && params.maxBpsToSponsor > 0) { revert AccountNotActivatedError(params.finalRecipient); } // Fall back unless FromUserFunds mode with an eligible activation token if (isStandard || !finalCoreTokenInfo.canBeUsedForAccountActivation) { emit AccountNotActivated(params.quoteNonce, params.finalRecipient); params.finalToken = initialToken; _fallbackHyperEVMFlow(params); return; } }

tbwebb22 · 2025-12-18T22:02:50Z

contracts/periphery/mintburn/HyperCoreFlowExecutor.sol

+                if (!coreTokenInfo.canBeUsedForAccountActivation) {
+                    _fallbackHyperEVMFlow(params);
+                    return;
+                }


Do we want to emit the AccountNotActivated event here?
If so, we could probably simplify this in a similar way to my other comment

Added events in 2c97a95

Looking into simplification

Signed-off-by: Ihor Farion <ihor@umaproject.org>

feat: Perp destination dex support

e2dbeb2

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

fusmanii requested review from grasphoper and tbwebb22 December 12, 2025 02:21

fusmanii added 3 commits December 12, 2025 12:17

depositFor for USDC

fab6286

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

fixed tests

7518d6b

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Merge branch 'master' of github.com:across-protocol/contracts into fa…

ea1581a

…isal/perp-destination-dex

fusmanii marked this pull request as ready for review December 15, 2025 17:20

fusmanii requested review from bmzig, mrice32, nicholaspai and pxrl as code owners December 15, 2025 17:20

tbwebb22 reviewed Dec 15, 2025

View reviewed changes

contracts/libraries/HyperCoreLib.sol Outdated Show resolved Hide resolved

fusmanii added 2 commits December 15, 2025 14:01

trust api with destination dex

02f5253

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

set spot as source

c661b36

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

fusmanii requested a review from tbwebb22 December 15, 2025 19:27

tbwebb22 reviewed Dec 15, 2025

View reviewed changes

contracts/periphery/mintburn/HyperCoreFlowExecutor.sol Show resolved Hide resolved

grasphoper reviewed Dec 15, 2025

View reviewed changes

grasphoper reviewed Dec 16, 2025

View reviewed changes

contracts/periphery/mintburn/sponsored-oft/ComposeMsgCodec.sol Outdated Show resolved Hide resolved

fusmanii and others added 6 commits December 16, 2025 16:30

add helper funcs

8b67259

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

fixed data indexes

57ecb45

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

updated cctp min msg length

21c2ad6

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

updated oft min msg length

e179c5e

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

correct read indicies + add test

bf69b2b

Signed-off-by: Ihor Farion <ihor@umaproject.org>

grasphoper reviewed Dec 17, 2025

View reviewed changes

contracts/periphery/mintburn/sponsored-oft/ComposeMsgCodec.sol Show resolved Hide resolved

Reinis-FRP reviewed Dec 17, 2025

View reviewed changes

contracts/libraries/SponsoredCCTPQuoteLib.sol Outdated Show resolved Hide resolved

Reinis-FRP reviewed Dec 17, 2025

View reviewed changes

contracts/interfaces/SponsoredCCTPInterface.sol Show resolved Hide resolved

Reinis-FRP mentioned this pull request Dec 17, 2025

fix: add destination dex and account creation mode #1225

Open

fusmanii and others added 4 commits December 17, 2025 09:44

update cctp min msg length

a393df4

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

updated SponsoredDepositForBurn with new fields

7624b3c

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

remove duplicate check from 2 places

2e5bb7e

Signed-off-by: Ihor Farion <ihor@umaproject.org>

fix params.commonParams.amountInEVM == 0 edge case

2218bf7

Signed-off-by: Ihor Farion <ihor@umaproject.org>

grasphoper changed the title ~~feat: Perp destination dex support~~ feat: transfer into Perp + account creation on the fly support Dec 18, 2025

grasphoper changed the title ~~feat: transfer into Perp + account creation on the fly support~~ feat: audit follow up Dec 18, 2025

fusmanii added do not merge do not merge need to audit This PR needs to be audited externally before deploying labels Dec 18, 2025

tbwebb22 reviewed Dec 18, 2025

View reviewed changes

contracts/periphery/mintburn/HyperCoreFlowExecutor.sol Outdated Show resolved Hide resolved

add return after falling back to EVM flow

ddf951a

Signed-off-by: Ihor Farion <ihor@umaproject.org>

tbwebb22 reviewed Dec 18, 2025

View reviewed changes

grasphoper added 5 commits December 18, 2025 14:28

fix account activation amounts logic for when finalizing the swap flow

2c97a95

Signed-off-by: Ihor Farion <ihor@umaproject.org>

simplify if conditions

c1a8b96

Signed-off-by: Ihor Farion <ihor@umaproject.org>

fix some problems and introduce a stack-too-deep :)

c10388e

Signed-off-by: Ihor Farion <ihor@umaproject.org>

fix stack too deep

5784205

Signed-off-by: Ihor Farion <ihor@umaproject.org>

smh fix

c4dd51e

Signed-off-by: Ihor Farion <ihor@umaproject.org>

feat: audit follow up #1218

Are you sure you want to change the base?

feat: audit follow up #1218

Uh oh!

Conversation

fusmanii commented Dec 12, 2025 • edited by grasphoper Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reinis-FRP Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

grasphoper Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reinis-FRP Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tbwebb22 Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

tbwebb22 Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

grasphoper Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fusmanii commented Dec 12, 2025 •

edited by grasphoper

Loading