-
Notifications
You must be signed in to change notification settings - Fork 65
feat(swap-ui): implement bridge routes alongside swap routes #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/gsteenkamp-port-existing-ui
Are you sure you want to change the base?
feat(swap-ui): implement bridge routes alongside swap routes #1948
Conversation
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
0xjorgen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments
| }; | ||
|
|
||
| type EnrichedTokenWithReachability = EnrichedToken & { | ||
| type TokenWithBalanceWithReachability = TokenWithBalance & { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps TokenWithBalanceAndReachability?
|
|
||
| // Show API error in button label if present | ||
| if (quoteWarningMessage && buttonState === "apiError") { | ||
| // todo: parse suggested fees errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to leave this todo here? If so, it is better if we capture it in linear.
Add Bridge-Only Route Support to SwapAndBridge
closes ACX-4632
Summary
This PR introduces support for bridge-only routes in the SwapAndBridge flow, allowing it to work alongside the existing swap-only route functionality. This enables users to bridge to external projects like Hyperliquid via the Arbitrum bridge, which was previously only available in the Bridge flow.
Test cases