feat: migrate from Jest to Vitest #2069
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xjorgen
requested review from
NikolasHaimerl,
amateima,
ashwinrava,
dohaki,
gsteenkamp89,
melisaguevara,
mrice32 and
nicholaspai
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Migrate test runner from Jest to Vitest for significantly improved performance: - Frontend tests: 77.9s → 2.1s (37x faster) - API tests: 84.4s → 7.6s (11x faster) Changes: - Add vitest.frontend.config.ts and vitest.api.config.ts - Use node environment by default, jsdom only for DOM-requiring tests - Convert jest.mock/fn/spyOn to vi.mock/fn/spyOn across 17 test files - Add setup.vitest.ts with TextEncoder polyfill - Inline @across-protocol/* packages to resolve ESM issues - Update package.json test scripts to use vitest Co-Authored-By: Claude <noreply@anthropic.com>
0xjorgen
force-pushed
the
jorgen/fe-213-migrate-to-vitest
branch
from
5517da9 to
f6378cc
Compare
0xjorgen
commented
Dec 9, 2025
| expect(token).toBeUndefined(); | ||
| }); | ||
|
|
||
| it("should return undefined for a zero address if the native token is not in the token map", () => { |
Contributor
Author
There was a problem hiding this comment.
this test messed up the other with the nested mock.
If it is important, we cen do the work of replacing it with another approach
| export default defineConfig({ | ||
| plugins: [react(), tsconfigPaths(), svgr()], | ||
| test: { | ||
| environment: "node", |
Contributor
There was a problem hiding this comment.
is it possible to use this part of the config to replace the // @vitest-environment jsdom directive?
Contributor
Author
There was a problem hiding this comment.
Yeah, if we add jsom here, we need to add this to the setup.vitest.ts file
// JSDom + Vitest don't play well with each other. Long story short - default
// TextEncoder produces Uint8Array objects that are _different_ from the global
// Uint8Array objects, so some functions that compare their types explode.
// https://github.com/vitest-dev/vitest/issues/4043#issuecomment-1905172846
class ESBuildAndJSDOMCompatibleTextEncoder extends TextEncoder {
constructor() {
super();
}
encode(input: string) {
if (typeof input !== "string") {
throw new TypeError("`input` must be a string");
}
const decodedURI = decodeURIComponent(encodeURIComponent(input));
const arr = new Uint8Array(decodedURI.length);
const chars = decodedURI.split("");
for (let i = 0; i < chars.length; i++) {
arr[i] = decodedURI[i].charCodeAt(0);
}
return arr;
}
}
global.TextEncoder = ESBuildAndJSDOMCompatibleTextEncoder;I suggest we keep the directives for now since so few tests depend on the dom env. If we split the repo in the future to only have frontend files, then it makes sense to have global dom environent
Contributor
There was a problem hiding this comment.
okay in that case let's stick with the directives 👍
package.json
Outdated
| "eslint-plugin-storybook": "^0.6.15", | ||
| "happy-dom": "^20.0.11", | ||
| "husky": "^8.0.0", | ||
| "jest": "^29.5.0", |
Contributor
There was a problem hiding this comment.
can we delete jest and its plugins?
Contributor
There was a problem hiding this comment.
that's wonderfully cheesy 😆
|
Deployment failed with the following error: Learn More: https://vercel.link/3Fpeeb1 |
added 2 commits
December 11, 2025 10:36
# Conflicts: # test/api/_bridges/cctp-sponsored/utils/signing.test.ts # test/api/_bridges/cctp/strategy.test.ts # test/api/_bridges/oft-sponsored/utils/signing.test.ts # test/api/_bridges/sponsored-intent/common.test.ts
added 2 commits
December 16, 2025 14:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fast unit tests are crucial for a good test writing experience. With AI, quick tests also let us iterate faster and run unit tests as part of workflow. Vite offers modern, easy-to-use testing tools and is notably faster.
Modification:
Migrate test runner from Jest to Vitest for significantly improved performance:
ci
before
after:
Changes:
Co-Authored-By: Claude noreply@anthropic.com