Skip to content

feat: update HyperliquidDepositHandler message #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dohaki wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: update HyperliquidDepositHandler message #2111

dohaki wants to merge 2 commits into from

Conversation

@dohaki
Copy link
Contributor

@dohaki dohaki commented Dec 16, 2025 •
edited
Loading

This updates the HyperliquidDepositHandler address to the latest deployment from https://hyperevmscan.io/address/0x420D76Aa59A56953C920a1D1451b0B73147334F1. Also updates the required message for this new handler.

NOTE: Only merge AFTER signer is set to the correct address in the handler contract

@linear
Copy link

linear bot commented Dec 16, 2025

ACB-25 Implement new message signing scheme for HyperliquidDepositHandler contract

@vercel
Copy link

vercel bot commented Dec 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
app-frontend-v3 Ready Ready Preview, Comment Dec 16, 2025 9:31am
sepolia-frontend-v3 Ready Ready Preview, Comment Dec 16, 2025 9:31am

NikolasHaimerl
NikolasHaimerl reviewed Dec 16, 2025
View reviewed changes
api/_bridges/sponsored-intent/utils/constants.ts
// Taken from https://hyperevmscan.io/address/0x420D76Aa59A56953C920a1D1451b0B73147334F1
export const HYPERLIQUID_DEPOSIT_HANDLER_ADDRESS =
"0x861E127036B28D32f3777B4676F6bbb9e007d195";
"0x420D76Aa59A56953C920a1D1451b0B73147334F1";
Copy link
Contributor

@NikolasHaimerl NikolasHaimerl Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also go with the across constants library, based on the info from this recent PR: https://github.com/across-protocol/contracts/blob/199910196f1f7b57b7c6e2e056260c78012b3b85/broadcast/deployed-addresses.json#L546

Copy link
Contributor Author

@dohaki dohaki Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too but the latest beta contracts version is still referring to 0x861E127036B28D32f3777B4676F6bbb9e007d195 and we need the new one

Copy link
Contributor

@NikolasHaimerl NikolasHaimerl Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, should we also notify the contracts team about this, or do they know anyway?
Will approve for now, but would be great if we can omit having to hardcode addresses.

Copy link
Contributor Author

@dohaki dohaki Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, if they release a non-beta version we should be able to pull addresses from there soon

@vercel
Copy link

vercel bot commented Dec 16, 2025

Deployment failed with the following error:

Hobby accounts are limited to daily cron jobs. This cron expression (* * * * *) would run more than once per day. Upgrade to the Pro plan to unlock all Cron Jobs features on Vercel.

Learn More: https://vercel.link/3Fpeeb1

@NikolasHaimerl NikolasHaimerl mentioned this pull request Dec 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikolasHaimerl NikolasHaimerl NikolasHaimerl approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@nicholaspai nicholaspai Awaiting requested review from nicholaspai nicholaspai is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

@melisaguevara melisaguevara Awaiting requested review from melisaguevara melisaguevara is a code owner

@amateima amateima Awaiting requested review from amateima amateima is a code owner

@ashwinrava ashwinrava Awaiting requested review from ashwinrava ashwinrava is a code owner

@gsteenkamp89 gsteenkamp89 Awaiting requested review from gsteenkamp89 gsteenkamp89 is a code owner

@0xjorgen 0xjorgen Awaiting requested review from 0xjorgen 0xjorgen is a code owner

Assignees

No one assigned

Labels

do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dohaki @NikolasHaimerl