fix: mark non-bridgable svm tokens as unreachable #2118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
Signed-off-by: Gerhard Steenkamp <gerhard@umaproject.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gsteenkamp89
requested review from
0xjorgen,
amateima,
dohaki,
mrice32 and
nicholaspai
as code owners
0xjorgen
reviewed
Dec 17, 2025
Contributor
0xjorgen
left a comment
0xjorgen
left a comment
There was a problem hiding this comment.
I posted one idea. Not sure if it is a good one though
| const isSolanaDestination = token.chainId === CHAIN_IDs.SOLANA; | ||
|
|
||
| // If Solana is not involved, don't mark as unreachable | ||
| if (!isSolanaOrigin && !isSolanaDestination) return false; |
Contributor
There was a problem hiding this comment.
knit !(isSolanaOrigin || isSolanaDestination) is equal to (!isSolanaOrigin && !isSolanaDestination) but might be easier to read? 🤔
| toSymbol: ["!USDC"], | ||
| }, | ||
| ]; | ||
|
|
Contributor
There was a problem hiding this comment.
would it be better if we extended the RESTRICTED_ROUTES to support multiple to symbols?
{
fromChainId: "*",
fromSymbol: ["*"],
toChainId: [CHAIN_IDs.SOLANA],
toSymbol: ["!USDC", "!USDH", "!USDH-SPOT", "!USDC-SPOT", "!USDT-SPOT"],
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes FE-84