fix: duplicate key race condition #512
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Race Conditions in Event Processing
The Problem
Our event ingestion pipeline was vulnerable to race conditions when concurrent processes indexed the same event. In PostgreSQL (
Read Committed), checking for a row's existence does not lock the "gap" if the row is missing. This caused two processes to seenullsimultaneously, leading to "Duplicate Key" errors and aborted transactions.The Solution
Implemented PostgreSQL Advisory Locks to strictly serialise processing for specific events without blocking the entire table.
Implementation Details
txHash+logIndex).pg_advisory_xact_lock) before DB operations.Benefits
See: https://www.postgresql.org/docs/current/explicit-locking.html#ADVISORY-LOCKS