chore: Refactor USDH Refiller to be more configurable #2800
Conversation
| } | ||
|
|
||
| // Default minimum is 10 USDH. USDH only exists on HyperEVM and has 6 decimals. | ||
| this.minUsdhRebalanceAmount = toBNWei(MIN_USDH_REBALANCE_AMOUNT ?? "10", 6); |
There was a problem hiding this comment.
I would maybe even prefer to move MIN_USDH_REBALANCE_AMOUNT to REFILL_BALANCES object level and we will be able to decide if we should check origin or destination balances based on this and not checkOriginChainBalance
wdyt?
There was a problem hiding this comment.
Yeah, that's not a bad idea 👍
dijanin-brat
requested review from
bmzig,
dohaki,
mrice32,
nicholaspai and
pxrl
as code owners
|
Before merging this PR, we should first update |
src/refiller/Refiller.ts
Outdated
| this.logger.debug({ | ||
| at: "Refiller#refillUsdh", | ||
| message: "Checking destination chain (HyperEVM) USDH balance", | ||
| destinationChainBalance: formatUnits(currentBalance, decimals), | ||
| triggerThreshold: formatUnits(triggerThreshold, decimals), | ||
| targetThreshold: formatUnits(targetThreshold, decimals), | ||
| shouldRefill, | ||
| }); | ||
|
|
||
| // Early exit if destination chain balance is above trigger | ||
| if (!shouldRefill) { | ||
| this.logger.debug({ | ||
| at: "Refiller#refillUsdh", | ||
| message: "Destination chain balance above trigger, skipping transfer", | ||
| destinationChainBalance: formatUnits(currentBalance, decimals), | ||
| triggerThreshold: formatUnits(triggerThreshold, decimals), | ||
| }); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think it probably only makes sense to emit one of these messages, not both (i.e. in the case of !shouldRefill.
pxrl
left a comment
pxrl
left a comment
There was a problem hiding this comment.
A couple of minor questions - hopefully easy to resolve these so we can get this merged soon 👍
| message: "Rebalanced Arbitrum USDC to HyperEVM USDH", | ||
| nonMulticall: true, | ||
| mrkdwn: `Sent ${formatUnits(amountToTransfer, decimals)} USDC from Arbitrum to HyperEVM.`, | ||
| const originChainBalance = await usdc.balanceOf(this.baseSignerAddress.toNative()); |
There was a problem hiding this comment.
Should this be accountAddress instead? (Based on line ~410 it seems like they should be interchangeable). Does it make sense for us to assert equality on accountAddress and this.baseSignerAddress.toNative() ?
| const accountAddress = account.toNative(); | ||
|
|
||
| // Early exit check: If checking destination chain balance, verify it's below trigger | ||
| if (!checkOriginChainBalance && currentBalance.gt(triggerThreshold)) { |
There was a problem hiding this comment.
Could we simplify the checkOriginChainBalance logic by always checking it, and enforcing the minimum rebalance amount, but defaulting that amount to 0? Then we can increase that limit when we want to impose a minimum, and otherwise it'd effectively revert to always rebalancing.
| minThreshold: formatUnits(this.config.minUsdhRebalanceAmount, decimals), | ||
| amountToTransfer: formatUnits(amountToTransfer, decimals), | ||
| }); | ||
| return null; |
There was a problem hiding this comment.
What if we returned { usdc, amountToTransfer: bnZero, accountAddress } in this case? it's arguably simpler wherever this is used, because the caller only needs to check for amountToTransfer.gt(bnZero).
We want to make USDH Refiller more configurable so it can top-up address on HyperEVM with USDH based on balances on both origin and destination chains.