-
Notifications
You must be signed in to change notification settings - Fork 101
WIP: Add RebalancerClient scaffolding for Inventory Management System 2.0 #2826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nicholaspai
wants to merge
35
commits into
master
Choose a base branch
from
rebalancer-scaffolding
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 2.0 This PR is designed to open the discussion on designing an improved inventory manager system that supports the following features: - Allows arbitrary any to any rebalances - Allows user to specify target balances instead of percentages, which are easier to reason about The current system is limited to L1->L2 and L2->L1 flows and it handles them separately with different clients, this makes the code harder to maintain and also difficult to implement L2 to L2 rebalancing.
next up is to place an order in initializeRebalances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is designed to open the discussion on designing an improved inventory manager system that supports the following features:
The current system is limited to L1->L2 and L2->L1 flows and it handles them separately with different clients, this makes the code harder to maintain and also difficult to implement L2 to L2 rebalancing.