-
Notifications
You must be signed in to change notification settings - Fork 81
Update programmatically-determined-link-context.md #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Updated the glossary section to remove 'aria-decribedby' and changed the description from 'set of all elements' to 'link's accessible description, combined with the set of all elements'
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kengdoj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add accessible name also
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made changes as requested by Kathy.
Jym77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add passed/failed examples of links with accessible description to the "link in context" rule.
I'm also not sure why we start a new PR instead of updating #1845 which is doing pretty much the same thing (adding accessible description), with more (adding examples) 🤔
Updated the glossary section to remove 'aria-decribedby' and changed the description from 'set of all elements' to 'link's accessible description, combined with the set of all elements'
<< Describe the changes >>
Closes issue(s):
b20e66,5effbb,aizyf1,fd3a94) consider thetitleattribute? #1766Need for Call for Review:
This will not require a Call for Review << choose reason(s): editorial changes (including to the applicability, expectation or examples section), changes to assumptions, background, accessibility support, change to website/test code (not rule), other (explain). >>
After creating PR:
When merging a PR: