Expand fitter error handling code #1177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
niermann999
approved these changes
Nov 7, 2025
stephenswat
force-pushed
the
bug/kf_error_codes
branch
from
cc0aeb8 to
0c782e2
Compare
Member
Author
Physics performance summaryHere is a summary of the physics performance effects of this PR. Command used: Seeding performanceTotal number of seeds went from 298345 to 298338 (-0.0%) Seeding plots
Track finding performanceTotal number of found tracks went from 55967 to 55963 (-0.0%) Finding plots
Track fitting performanceFitting plots
Note This is an automated message produced on the explicit request of a human being. |
This commit updates the Kálmán fitter error handling code by explicitly marking failures in the forward and backwards fitting step. It also resolves an issue where the smoother would start from invalid track states.
stephenswat
force-pushed
the
bug/kf_error_codes
branch
from
0c782e2 to
11de53a
Compare
|
Member
Author
Physics performance summaryHere is a summary of the physics performance effects of this PR. Command used: Seeding performanceTotal number of seeds went from 298345 to 298344 (-0.0%) Seeding plots
Track finding performanceTotal number of found tracks went from 50745 to 50744 (-0.0%) Finding plots
Track fitting performanceFitting plots
Seeding to track finding relative performanceSeeding to track finding plots
Track finding to track fitting relative performanceTrack finding to track fitting plots
Note This is an automated message produced on the explicit request of a human being. |
niermann999
added a commit
that referenced
this pull request
Nov 13, 2025
Expand on the number of Kalman fit status codes and track fit outcomes to make a more fine-grained distinction between different error types in the Kalman fitter possible. Takes up the improvements in #1177. Edit: The wire chamber Kalman fitter test had to be adapted, because more error states are recognized Edit2: Also fixed the condition of is_complete for the backward fit to point one position below the first state
StewMH
pushed a commit
to StewMH/traccc
that referenced
this pull request
Nov 19, 2025
Expand on the number of Kalman fit status codes and track fit outcomes to make a more fine-grained distinction between different error types in the Kalman fitter possible. Takes up the improvements in acts-project#1177. Edit: The wire chamber Kalman fitter test had to be adapted, because more error states are recognized Edit2: Also fixed the condition of is_complete for the backward fit to point one position below the first state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Kálmán fitter error handling code by explicitly marking failures in the forward and backwards fitting step. It also resolves an issue where the smoother would start from invalid track states.