Seeding/Sequence Example Rewrite, main branch (2025.11.21.) #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though it seems that it's not quite working correctly still. :(
These are meant as replacements for the separate seq_example applications.
Copying the code from acts-project#1206, as the rebasing couldn't help with preserving it.
krasznaa
force-pushed
the
SeedingExampleRewrite-main-20251119
branch
from
2904678 to
5d38695
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try to prepare things a bit for the coming HIP code (#1193), this is a proposal for how we could manage the example applications between the different backends.
The PR introduces "device backend" types as part of the examples. Which would provide enough information such that a common templated code could implement the applications. Similar to how we've done it for the throughput applications since forever.
Since the "device backends" are written a bit verbosely, the number of saved lines of code in the PR is not as good as I would've hoped. But remember that adding applications for the HIP backend should become much simpler after this. Plus the maintenance of these applications should also simplify.
Note:
seq" and "seeding" applications for now. Since the host applications fundamentally do a different thing, I don't think those would fit under this umbrella.Finally: @stephenswat, I tried to implement the new applications such that your existing scripts could switch to these with minimal effort. But I'll need your input on how that should go exactly.