feat: Build detectors with custom metadata

[niermann999]

Build the ODD and ITk detectors with their custom metadata. Also remove the io roundtrip in the tests for the telescope and toy detector, since the custom metadata of the test detectors is already getting compiled and they do not need to be read into the default detector anymore

[krasznaa]

Just to make your life more difficult.

[krasznaa]

The CMake part I was able to update pretty quickly. But the code is unfortunately quite broken in the PR at the moment. 😦 The changes in the tests will have to be reverted. Or the tests will need to be much more re-written.

I can show you the details tomorrow, but basically, the toy detector and telescope fitting tests deeply assume at the moment that they would use the same detector type. As the detector type is defined in a common base class to these tests. So the unit tests are just crashing in this PR at the moment. 😦

Again, to be discussed tomorrow...

[krasznaa]

You can find my CMake changes here: krasznaa@6103b5e

[niermann999]

You can find my CMake changes here: krasznaa@6103b5e

Thank you, I will have have look

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[stephenswat]

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

Kernel	Reciprocal Throughput			Parallelism
	8e3edfd	90de67f	Delta	8e3edfd	90de67f
propagate_to_next_surface	8.40 ms	6.25 ms	-25.6%	3.48	4.27
fit_forward	2.04 ms	1.92 ms	-6.0%	7.34	7.34
find_tracks	1.38 ms	1.38 ms	-0.1%	1.81	1.81
ccl_kernel	823.77 μs	823.42 μs	-0.0%	1.37	1.37
fit_backward	1.10 ms	670.36 μs	-39.1%	5.50	5.49
count_doublets	622.61 μs	613.53 μs	-1.5%	1.61	1.61
count_triplets	588.96 μs	588.60 μs	-0.1%	1.02	1.02
find_doublets	444.54 μs	445.88 μs	0.3%	3.08	3.08
Thrust::sort	384.92 μs	384.77 μs	-0.0%	7.36	7.36
find_triplets	173.65 μs	172.24 μs	-0.8%	1.31	1.31
select_seeds	53.04 μs	53.79 μs	1.4%	1.34	1.34
remove_duplicates	23.67 μs	23.68 μs	0.1%	26.05	26.01
populate_grid	23.49 μs	23.36 μs	-0.5%	1.22	1.22
count_grid_capacities	22.21 μs	22.12 μs	-0.4%	1.22	1.22
fill_sorted_measurements	19.74 μs	19.70 μs	-0.2%	1.13	1.13
update_triplet_weights	14.96 μs	14.97 μs	0.1%	1.27	1.27
estimate_track_params	14.26 μs	14.26 μs	-0.0%	2.15	2.15
apply_interaction	14.25 μs	13.96 μs	-2.0%	6.72	6.65
fit_prelude	9.82 μs	9.82 μs	-0.0%	21.78	21.78
fill_finding_propagation_sort_keys	8.86 μs	8.83 μs	-0.3%	7.60	7.62
form_spacepoints	7.94 μs	8.23 μs	3.7%	1.48	1.48
reduce_triplet_counts	6.28 μs	6.27 μs	-0.2%	3.08	3.08
unknown	5.04 μs	5.05 μs	0.3%	4.28	4.27
build_tracks	4.10 μs	4.09 μs	-0.2%	14.78	14.78
fill_finding_duplicate_removal_sort_keys	1.57 μs	1.57 μs	0.1%	37.97	37.95
fill_prefix_sum	171.95 ns	171.97 ns	0.0%	341.30	341.30
fill_fitting_sort_keys	153.36 ns	152.68 ns	-0.4%	22.08	22.08
Total	16.20 ms	13.48 ms	-16.7%	3.79	4.12

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Note

This is an automated message produced upon the explicit request of a human being.

[krasznaa]

As long as all the latest CI tests succeed...

[stephenswat]

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298345 to 298342 (-0.0%)

Seeding plots

Track finding performance

Total number of found tracks went from 50184 to 50186 (+0.0%)

Finding plots

Track fitting performance

Fitting plots

Seeding to track finding relative performance

Seeding to track finding plots

Track finding to track fitting relative performance

Track finding to track fitting plots

Note

This is an automated message produced on the explicit request of a human being.