C17 - Sea Turtles - Shannon Bellemore#110
Open
eggoweggo wants to merge 4 commits intoada-c17:mainfrom
Open
Conversation
tgoslee
reviewed
Jul 12, 2022
tgoslee
left a comment
tgoslee
left a comment
There was a problem hiding this comment.
Great job Shannon! Let me know if you have any questions on what I reviewed.
| const [entries, setEntries] = useState(chatMessages); | ||
| const [likesTotal, setLikesTotal] = useState(0); | ||
|
|
||
| const changeLikes = (id) => { |
|
|
||
| const ChatEntry = (props) => { | ||
| const likedEntry = () => { | ||
| props.changeLikes(props.id) |
There was a problem hiding this comment.
great job just passing the id and letting the code in App,js handle creating the object.
| <TimeStamp time={props.timeStamp} /> | ||
| </p> | ||
| <button onClick={likedEntry} className="like"> | ||
| {props.liked ? '❤️':'🤍'} |
| import ChatEntry from './ChatEntry'; | ||
|
|
||
| const ChatLog = (props) => { | ||
| const chatEntryComponents = props.entries.map((entry) => { |
There was a problem hiding this comment.
I see that you are getting an error about each entry having a unique key. Even though I see you using the entry id on line 9, I would suggest using the index from the map function
const ChatEntryComponents = props.entries.map((entry, index) => {
...
<ChatEntry
key={index}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.