Update adafruit_qtpy_esp32s3_* boards wifi power settings to fix common wifi connectivity issues#10919
Closed
jesseadams wants to merge 2 commits intoadafruit:mainfrom
Closed
Update adafruit_qtpy_esp32s3_* boards wifi power settings to fix common wifi connectivity issues#10919jesseadams wants to merge 2 commits intoadafruit:mainfrom
jesseadams wants to merge 2 commits intoadafruit:mainfrom
Conversation
…ifi connectivity issues This is related to adafruit#10914. This matches the setting for [adafruit_qtpy_esp32c3](https://github.com/adafruit/circuitpython/blob/main/ports/espressif/boards/adafruit_qtpy_esp32c3/mpconfigboard.h)
jesseadams
changed the title
Collaborator
|
As mentioned in #10914 (comment), I am kind of inclined to do this for both ESP32-S3 QT Py's, but others may disagree. |
Author
|
@dhalbert Added it for adafruit_qtpy_esp32s3_4mbflash_2mbpsram as well. |
jesseadams
changed the title
Collaborator
|
Would you be willing to revise this to be against the Unfortunately does not work to just change the base, because you'll drag in a lot of commits. You may need to close this and reopen a new one. |
Author
|
@dhalbert My bad - CircuitPython contributor noob. Please stand by 😃 |
Collaborator
|
@jesseadams Not your bad. The choice of branch here has more to do with the expected arrival time of 10.2.0 vs the next 10.1.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #10914.
This matches the setting for adafruit_qtpy_esp32c3