Skip to content

issue 1846 - remove the locale parameter of Notification.getLocalizedTexts #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

issue 1846 - remove the locale parameter of Notification.getLocalizedTexts #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ed57c9
issue #5504 fix
jaels Feb 7, 2018
ec91d33
issue #1846 fix - new
jaels Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/filterStorage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ let FilterStorage = exports.FilterStorage =
/**
* @typedef FileInfo
* @type {object}
* @property {nsIFile} file
* @property {number} index
* @property {number} lastModified
*/

Expand Down
7 changes: 2 additions & 5 deletions lib/notification.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,13 +404,10 @@ let Notification = exports.Notification =
/**
* Localizes the texts of the supplied notification.
* @param {Object} notification notification to translate
* @param {string} locale the target locale (optional, defaults to the
* application locale)
* @return {Object} the translated texts
*/
getLocalizedTexts(notification, locale)
getLocalizedTexts(notification)
{
locale = locale || Utils.appLocale;
let textKeys = ["title", "message"];
let localizedTexts = {};
for (let key of textKeys)
Expand All @@ -420,7 +417,7 @@ let Notification = exports.Notification =
if (typeof notification[key] == "string")
localizedTexts[key] = notification[key];
else
localizedTexts[key] = localize(notification[key], locale);
localizedTexts[key] = localize(notification[key], Utils.appLocale);
}
}
return localizedTexts;
Expand Down
Loading