fix: handle all authorization types in get_properties_by_agent #100
+328
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #99 - get_properties_by_agent() now handles all AdCP v2 authorization types: - inline_properties: Properties defined directly on the agent - property_ids: Filter top-level properties by property_id - property_tags: Filter top-level properties by tags - publisher_properties: Cross-domain property selectors Also fixes AuthorizationContext to use "property_id" field per AdCP v2 schema instead of the incorrect "id" field. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #99:
get_properties_by_agent()now handles all AdCP v2 authorization types (inline_properties, property_ids, property_tags, publisher_properties) and AuthorizationContext now uses the correct "property_id" schema field.Changes
get_properties_by_agent()to filter top-level properties by ID and tagsAuthorizationContextto use "property_id" instead of incorrect "id" fieldTests
All 70 adagents tests and full suite (387 tests) pass. Code passes linter checks.