-
Notifications
You must be signed in to change notification settings - Fork 1
feat: update adcp types for latest push notification schemas and update utility functions around webhooks #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fdff941 to
6cba9ef
Compare
nastassiafulconis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! The webhook utilities are a great addition. I found a few issues that need addressing before we can merge - mostly around signature verification security. See inline comments below.
nastassiafulconis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! The webhook utilities are a great addition. Found a few things that need addressing - mostly around signature verification. See inline comments.
|
A few more things I noticed: client.py signature verification - double check that the verification strips the tests - solid coverage! one thing that might be worth adding is an end-to-end test that creates a payload with breaking changes - might be worth noting in the PR description that the |
Description
This PR updates python generated types after push notification schema changes made to the adcp protocol:
Also, updates/adds utility functions for handling and creating webhook payloads specifically utilities:
create_a2a_webhook_payloadcreate_mcp_webhook_payloadget_adcp_signed_headers_for_webhookDemo (MCP)
sync creative approval and rejection
https://www.loom.com/share/930fb382e5404b6b8cd77196f5a398a0
media buy approval
https://www.loom.com/share/22ac869407ad4834ac5bae968b3c4237
Demo (A2A)
media buy approval
https://www.loom.com/share/7f86b1032164429882d906a3e07540da
creative approval
https://www.loom.com/share/11972d1ab2af4672a50363b74c531434