-
Notifications
You must be signed in to change notification settings - Fork 23
Add auction pricing for all pricing models #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EmmaLouise2018
wants to merge
3
commits into
main
Choose a base branch
from
auction-all-pricing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| --- | ||
| "adcontextprotocol": minor | ||
| --- | ||
|
|
||
| Add auction pricing for all pricing models | ||
|
|
||
| Previously only CPM and vCPM supported both fixed and auction pricing. Now all pricing models support both variants: | ||
| - CPM, vCPM (already supported) | ||
| - CPC (Cost Per Click) | ||
| - CPCV (Cost Per Completed View) | ||
| - CPV (Cost Per View) | ||
| - CPP (Cost Per Point) | ||
| - Flat Rate | ||
|
|
||
| **Schema Architecture:** | ||
| Each pricing model has its own schema file that supports both fixed and auction variants using a discriminated union: | ||
| - `is_fixed: true` → uses `rate` field for fixed pricing | ||
| - `is_fixed: false` → uses `price_guidance` field for auction pricing | ||
|
|
||
| **7 pricing model schemas:** | ||
| - cpm-option.json | ||
| - vcpm-option.json | ||
| - cpc-option.json | ||
| - cpcv-option.json | ||
| - cpv-option.json | ||
| - cpp-option.json | ||
| - flat-rate-option.json | ||
|
|
||
| **TypeScript type safety:** | ||
| Uses proper discriminated union with `is_fixed` as the discriminator, enabling TypeScript to narrow types correctly: | ||
| - `if (opt.is_fixed) { opt.rate... }` | ||
| - `else { opt.price_guidance... }` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly use the testable code to make these maintainable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion! For pricing-models.mdx, the JSON examples are schema documentation rather than API calls, so
testable: trueisn't directly applicable here (those tests validate executable code against the test agent API).However, the schema validation tests do indirectly validate these structures since they test the pricing option schemas. The examples in the doc should match the schema definitions.
If we want explicit validation of doc examples, we could add a test that extracts JSON from the mdx and validates against schemas - happy to add that if useful.