-
Notifications
You must be signed in to change notification settings - Fork 23
Version Packages #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-actions
wants to merge
1
commit into
main
Choose a base branch
from
changeset-release/main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Version Packages #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a241168 to
b437555
Compare
b437555 to
e4f3228
Compare
e4f3228 to
c8fd6de
Compare
c8fd6de to
5f3d80c
Compare
5f3d80c to
075774e
Compare
075774e to
06edc16
Compare
06edc16 to
675bea4
Compare
675bea4 to
cb6c914
Compare
cb6c914 to
2dde5c3
Compare
2dde5c3 to
a5ceed6
Compare
a5ceed6 to
a5977bb
Compare
a5977bb to
0c6808e
Compare
0c6808e to
59f2786
Compare
59f2786 to
81448fd
Compare
81448fd to
18c8494
Compare
6b5aa58 to
d61f5de
Compare
d61f5de to
56ac151
Compare
56ac151 to
5a6177c
Compare
5a6177c to
c62678d
Compare
c62678d to
03988c7
Compare
03988c7 to
387ea5e
Compare
387ea5e to
51119df
Compare
51119df to
ecc90ed
Compare
ecc90ed to
2bf5694
Compare
2bf5694 to
6e40dbf
Compare
6e40dbf to
f0536c7
Compare
f0536c7 to
d2ced29
Compare
d2ced29 to
7b6b07f
Compare
7b6b07f to
69ef658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
adcontextprotocol@2.5.1
Patch Changes
72a5802: Fix semantic version sorting for agreements. When multiple agreement versions share the same effective date, the system now correctly selects the highest version (e.g., 1.1.1 before 1.1).
935eb43: Fix JSON Schema validation failures when using allOf composition with additionalProperties: false.
Schemas using
allOfto compose with base schemas (dimensions.json, push-notification-config.json) were failing AJV validation because each sub-schema independently rejected the other's properties.Fixed schemas:
dimensions.json- removedadditionalProperties: false(composition-only schema)push-notification-config.json- removedadditionalProperties: false(used via allOf in reporting_webhook)video-asset.json- inlined width/height properties, removed allOfimage-asset.json- inlined width/height properties, removed allOfAdded:
test:composedscript to validate data against schemas using allOf composition/schemas/{version}/bundled/for tools that don't support $ref resolutionFixes allOf + additionalProperties: false in asset schemas causes validation failures for official examples #275.
10d5b6a: Fix analytics dashboard revenue tracking with Stripe webhook customer linkage
64b08a1: Redesign how AdCP handles push notifications for async tasks. The key change is separating what data is sent (AdCP's responsibility) from how it's delivered (protocol's responsibility).
Renamed:
webhook-payload.json→mcp-webhook-payload.json(clarifies this envelope is MCP-specific)Created:
async-response-data.json- Union schema for all async response data typesworking,input-required, andsubmittedstatusesDeleted:
-async-response-completed.jsonand-async-response-failed.jsonfiles (6 total)completed/failed, we now use the existing task response schemas directlyBefore: The webhook spec tried to be universal, which created confusion about how A2A's native push notifications fit in.
After:
mcp-webhook-payload.jsonas its envelope, with AdCP data inresultTask/TaskStatusUpdateEventmessages, with AdCP data instatus.message.parts[].dataThis makes it clear that AdCP only specifies the data layer, while each protocol handles delivery in its own way.
Schemas:
static/schemas/source/core/mcp-webhook-payload.json(renamed + simplified)static/schemas/source/core/async-response-data.json(new)static/schemas/source/media-buy/*-async-response-*.json(6 deleted, 9 remain)Clarified that both MCP and A2A use HTTP webhooks (A2A's is native to the spec, MCP's is AdCP-provided)
Fixed webhook trigger rules: webhooks fire for all status changes if
pushNotificationConfigis provided and the task runs asyncAdded proper A2A webhook payload examples (
TaskvsTaskStatusUpdateEvent)Task Management added to sidebar, it was missing