Fix MCP response format docs to use flat structure #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update documentation to show MCP responses with task-specific fields
at the top level instead of nested inside a `data` wrapper.
This aligns docs with what @adcp/client actually expects:
- `response.products` instead of `response.data.products`
- `response.media_buy_id` instead of `response.data.media_buy_id`
Files updated:
- mcp-guide.mdx: Updated response format section and examples
- core-concepts.mdx: Updated response structure and code examples
- getting-started.mdx: Updated MCP quick comparison example
- protocol-comparison.mdx: Updated all MCP response examples
- a2a-guide.mdx: Fixed incorrect `response.data` usage in A2A context
Note: A2A examples correctly remain with `{"kind": "data", "data": {...}}`
inside artifact parts, which is proper A2A protocol structure.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
nastassiafulconis
requested review from
bokelley and
youbek
and removed request for
bokelley
youbek
approved these changes
Dec 17, 2025
bokelley
reviewed
Dec 17, 2025
…creatives Instead of showing raw A2A artifact parsing code, reference the sync_creatives task reference which has proper testable examples using @adcp/client. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
datawrapper@adcp/clientactually expectsContext
Swivel was implementing their MCP salesagent following our docs, but their implementation didn't match what
@adcp/clientexpects. The docs showed:{ "status": "completed", "data": { "products": [...] } }But
@adcp/clientexpects:{ "status": "completed", "products": [...] }Changes
Files updated:
docs/protocols/mcp-guide.mdx- Updated response format section and examplesdocs/protocols/core-concepts.mdx- Updated response structure and code examplesdocs/protocols/getting-started.mdx- Updated MCP quick comparison exampledocs/protocols/protocol-comparison.mdx- Updated all MCP response examplesdocs/protocols/a2a-guide.mdx- Fixed incorrectresponse.datausage in A2A contextKey changes:
response.data.products→response.productsresponse.data.media_buy_id→response.media_buy_idresponse.data?.errors→response.errorsNote: A2A examples correctly remain with
{"kind": "data", "data": {...}}inside artifact parts, which is proper A2A protocol structure.Test plan
🤖 Generated with Claude Code