Improve release workflow and switch from VSCode to Zed config#4
Conversation
WalkthroughThis PR updates the release workflow with stricter gates and reorganized steps, transitions editor configuration from VSCode to Zed, updates several devDependencies, expands ignore patterns in knip configuration, and refactors a trailing-zero truncation check in the formatting utility using optional chaining. Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
knip.json (1)
27-39: Deduplicate Knip ignore patterns.These repeated entries are harmless but create unnecessary config churn and reduce readability.
Proposed cleanup
"ignoreFiles": [ "**/dist/**", "**/build/**", "**/coverage/**", "**/.next/**", "**/.vercel/**", "**/.turbo/**", - "**/.context/**", - "**/dist/**", - "**/build/**", - "**/coverage/**", - "**/.next/**", - "**/.vercel/**", - "**/.turbo/**" + "**/.context/**" ], "ignore": [ "**/*.d.ts", - ".context/**", - "**/*.d.ts" + ".context/**" ],🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@knip.json` around lines 27 - 39, The ignore lists in knip.json contain duplicate glob entries (e.g., "**/*.d.ts" repeated and both ".context/**" and "**/.context/**" present); update the "ignore" array to remove duplicates and keep consistent glob forms (prefer "**/.context/**" vs ".context/**" and a single "**/*.d.ts") so each pattern appears only once; edit the "ignore" key in knip.json to deduplicate these strings while preserving the intended ignored paths.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release.yml:
- Around line 21-24: The if condition in the release workflow contains an
unsatisfiable clause: "github.event.workflow_run.event == 'workflow_run'";
remove that clause from the "if:" expression (or, if you intended to ensure this
job only runs when the workflow is triggered by a workflow_run event, replace
that clause with "github.event_name == 'workflow_run'") so the final condition
checks the real values (e.g., github.event.workflow_run.conclusion == 'success'
&& github.event.workflow_run.head_branch == 'main' or include github.event_name
== 'workflow_run' as needed).
---
Nitpick comments:
In `@knip.json`:
- Around line 27-39: The ignore lists in knip.json contain duplicate glob
entries (e.g., "**/*.d.ts" repeated and both ".context/**" and "**/.context/**"
present); update the "ignore" array to remove duplicates and keep consistent
glob forms (prefer "**/.context/**" vs ".context/**" and a single "**/*.d.ts")
so each pattern appears only once; edit the "ignore" key in knip.json to
deduplicate these strings while preserving the intended ignored paths.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
.github/workflows/release.yml.vscode/settings.json.zed/settings.jsonknip.jsonpackage.jsonsrc/lib/format.ts
💤 Files with no reviewable changes (1)
- .vscode/settings.json
| if: >- | ||
| github.event.workflow_run.conclusion == 'success' && | ||
| github.event.workflow_run.event == 'workflow_run' && | ||
| github.event.workflow_run.head_branch == 'main' |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
GitHub Actions workflow_run event github.event.workflow_run.event what does it represent
💡 Result:
In a workflow triggered by on: workflow_run, github.event.workflow_run.event is the name of the GitHub event that triggered the upstream (triggering) workflow run—e.g. push, pull_request, schedule, workflow_dispatch, etc. You can see this event field on workflow run objects (example shows "event": "push"), and the REST API lets you filter workflow runs by that triggering event. [1]
This is not the same as the workflow_run trigger’s activity type (requested, in_progress, completed) used in on.workflow_run.types. [2]
Sources: [1] [3]
References:
[1] (docs.github.com)
[2] (docs.github.com)
[3] (docs.github.com)
Citations:
- 1: https://docs.github.com/v3/actions/workflow-runs
- 2: https://docs.github.com/en/enterprise-server%403.15/actions/reference/workflows-and-actions/events-that-trigger-workflows?utm_source=openai
- 3: https://docs.github.com/v3/actions/workflow-runs
🏁 Script executed:
cat -n .github/workflows/release.yml | head -40Repository: adelrodriguez/qte
Length of output: 1219
Remove unsatisfiable condition preventing releases.
At line 23, github.event.workflow_run.event == 'workflow_run' is incorrect. In GitHub Actions, github.event.workflow_run.event contains the name of the event that triggered the upstream workflow (e.g., push, pull_request), never 'workflow_run'. This condition will always fail and prevent this job from running for successful main builds.
Proposed fix
if: >-
github.event.workflow_run.conclusion == 'success' &&
- github.event.workflow_run.event == 'workflow_run' &&
github.event.workflow_run.head_branch == 'main'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if: >- | |
| github.event.workflow_run.conclusion == 'success' && | |
| github.event.workflow_run.event == 'workflow_run' && | |
| github.event.workflow_run.head_branch == 'main' | |
| if: >- | |
| github.event.workflow_run.conclusion == 'success' && | |
| github.event.workflow_run.head_branch == 'main' |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/release.yml around lines 21 - 24, The if condition in the
release workflow contains an unsatisfiable clause:
"github.event.workflow_run.event == 'workflow_run'"; remove that clause from the
"if:" expression (or, if you intended to ensure this job only runs when the
workflow is triggered by a workflow_run event, replace that clause with
"github.event_name == 'workflow_run'") so the final condition checks the real
values (e.g., github.event.workflow_run.conclusion == 'success' &&
github.event.workflow_run.head_branch == 'main' or include github.event_name ==
'workflow_run' as needed).
1 participant
This pull request enhances the GitHub Actions release workflow and updates development tooling:
Release Workflow Improvements:
Development Environment Changes:
Code Quality Fix:
formatMultiPrecisionfunction where the condition!last || last.value !== 0could incorrectly break whenlastis falsy, changed tolast?.value !== 0