Improve indirect variable expansion in quickstart.sh#5504
Open
singhhnitin wants to merge 1 commit intoaden-hive:mainfrom
Open
Improve indirect variable expansion in quickstart.sh#5504singhhnitin wants to merge 1 commit intoaden-hive:mainfrom
singhhnitin wants to merge 1 commit intoaden-hive:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves indirect environment variable expansion in quickstart.sh
by introducing a temporary variable for safer API key detection.
It preserves the existing behavior while making detection more reliable.
Type of Change
Related Issues
Fixes #5483
Changes Made
env_varfor indirect expansionTesting
Describe the tests you ran to verify your changes:
cd core && pytest tests/)cd core && ruff check .)The quickstart script was executed locally to confirm that:
Checklist