[micro-fix] fix(security): H-07 — Prevent path traversal in credential IDs#5594
Open
shibinsp wants to merge 1 commit intoaden-hive:mainfrom
Open
[micro-fix] fix(security): H-07 — Prevent path traversal in credential IDs#5594shibinsp wants to merge 1 commit intoaden-hive:mainfrom
shibinsp wants to merge 1 commit intoaden-hive:mainfrom
Conversation
Replace character-by-character slash/dot replacement with a strict allowlist regex that only permits alphanumeric, hyphens, and underscores in credential IDs. Applied to both: - LocalFileStorage._cred_path() — with additional resolved-path check - HashiCorpVault._path() — with strict regex sanitization The previous approach (replacing / and \\ with _) missed encoded sequences, null bytes, and other traversal vectors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5563
Summary
Adds strict input sanitization to credential IDs to prevent path traversal attacks.
Severity: 🟠 High — Crafted credential IDs could access files outside the credential store.
Changes
Files Changed
framework/credential_storage.py— +15 linesTest Plan