-
Notifications
You must be signed in to change notification settings - Fork 18
PySEP v0.7.0 #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PySEP v0.7.0 #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* recsec now properly accounting for zero pad when calculating time offsets. * added a visual test for catching zero pad issue #149, this is a manual test for now so it's skipped
* new feature for exporting processed traces from recsec * started test function for mismatched location case added better error checking in check parameters to catch when subsetting removes all streams * small updates to text * remove debugger statement * allow command line input of xlim_s be float
… time (#153) * forcing microsecond to millisecond conversion in sac header * turning off test debugging * typo fix in sac header append * updating a test to cover nzmsec issue * no warning for missing sac header if list is empty * bugfixing sac header nzmsec was overflowing causing incorrect sac header times * removing debug statements
…ect start and end times leading to incorrectly scaled data-synthetic record sections when combining scale_by normalize and xlim_s #156
…and was locked behind the preprocessing flags. moved out and now trimming occurs on the global start and end times represented by both data and synthetics #157
…mand line since all kwargs are input as strings
* adding kwargs and plot aesthetics to documentation #119 * adding write_files and plot_file to the pysep doc page * #162 adds new recsec scale_by option 'rel_norm' which now normalizes pairs of traces to the largest amplitude between the both of them, preserving relative amplitudes per pair of traces * rearranging recsec parameter input order to match docstring #163 * #163 rearranging PySEP input parameters to match docstring * adding rel_norm to recsec docstring * bugfix recsec caused by trim fix that was expanding st and causing certain sort types to fail due to index errors * fixing failing tests
…indexing arrays when only selecting specific components
* adding 'time_shift_s_syn' as a way for user to time shift synthetics separately from data, if has the same traits as 'time_shift_s' but if not given it will take on values of 'time_shift_s' to retain original functionality adding tests to cover time_shift_s_syn and expand coverage over use cases of time_shift_s * two more tests to cover the use cases of time_shift_s_syn * added recsec kwargs obs_zorder and syn_zorder to allow user to set order of plotting, added more tests to cover time_shift_s and time_shift_s_syn updated docs to cover zorder parameters * all tests passing * updating time_shift_s_syn behavior so that if time shifts are the same for both obs and syn, no new labels need to be plottedto keep clutter down * small bugfix in logic * fixing implementation of recsec debug log messages when using time_shift_s_syn small bugfix time_shift_s_syn by default wasn't taking the properly formatted copy of time_shift_s
This was referenced Jun 5, 2025
* rearrange sac header writer move sac header writer after preprocess (trim rewrite b, e, and origin time) * update cap_sac.py with the nzmsec conversion reinstate the nzmsec conversion
…ting a list requires a list of certain length
…ne to functionality
… done with copilot so hopefully it's right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PySEP version 0.7.0, update summary below, see relevant PRs for more information. Thanks to @aakash10gupta and @casarotti for contributions.
--remove_locationsand--export_traces--scale_by 'rel_norm', improves docstrings and documentation--time_shift_s_syn,--obs_zorder,--syn_zorder, improves docstrings and documentation