feat: Add default value support for parameters#743
Open
dsabre wants to merge 1 commit intoadnanh:masterfrom
Open
feat: Add default value support for parameters#743dsabre wants to merge 1 commit intoadnanh:masterfrom
dsabre wants to merge 1 commit intoadnanh:masterfrom
Conversation
adnanh
reviewed
Feb 13, 2026
|
|
||
| if err != nil || paramsValueSliceLength <= int(index) { | ||
| // Return default value if nothing found and defaultValue is set | ||
| if defaultValue != "" { |
Owner
There was a problem hiding this comment.
I think we would need a mechanism for figuring out whether the default value is actually set in the configuration as null and empty string "" could also be valid default values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
defaultkeyword inpass-arguments-to-command.When provided, this value is used if the user does not supply the argument or if it is empty, instead of raising an error or using an empty value.
Documentation updated in
docs/Referencing-Request-Values.md.Example:
{ "source": "url", "name": "q", "default": "123" }In this example, if the URL query does not contain
qor it is empty, the value"123"will be used.If
defaultis omitted, the behavior remains unchanged.