Skip to content

fix: update to s2s credentials #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moritzraho merged 3 commits into from
Jul 17, 2025
Merged

fix: update to s2s credentials #178

moritzraho merged 3 commits into from
Jul 17, 2025

Conversation

@moritzraho
Copy link
Member

@moritzraho moritzraho commented Jul 16, 2025 •
edited
Loading

Description

depends on adobe/aio-lib-ims#168
run: https://github.com/adobe/aio-e2e-tests/actions/runs/16318881408

  • the run fails because of the ims test not being merged yet, this is ok, tested locally
  • there are also 2 events tests which fail since a while, must be due to a breaking change in the api..

NOTE: I've added the new secrets without removing the jwt ones

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

shazron
shazron approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7700 lines deleted, yes!

@moritzraho moritzraho merged commit 6f66e21 into master Jul 17, 2025
8 of 10 checks passed
@moritzraho moritzraho deleted the fix/update-to-s2s branch July 17, 2025 08:08
@moritzraho moritzraho mentioned this pull request Jul 23, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shazron shazron shazron approved these changes

@sandeep-paliwal sandeep-paliwal sandeep-paliwal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moritzraho @shazron @sandeep-paliwal