Skip to content

Fix CI and buildx for GitHub Actions Docker 29.x after reverting #223#225

Merged
shanejbrown merged 2 commits intoadobe:mainfrom
shanejbrown:r9264
Feb 18, 2026
Merged

Fix CI and buildx for GitHub Actions Docker 29.x after reverting #223#225
shanejbrown merged 2 commits intoadobe:mainfrom
shanejbrown:r9264

Conversation

@shanejbrown
Copy link
Contributor

@shanejbrown shanejbrown commented Feb 12, 2026

Summary

This PR does two things:

  1. Reverts merge of Add step-specific tags to prevent tag collisions #223 (commit 508ead7)

    • Undoes the retagging/multiplatform config and related changes from that merge.
  2. Fixes CI and buildx for current GitHub Actions runners (commit 74d0aaa)

    • Tests were failing after GitHub upgraded the runner environment (Docker 28.0.4 → 29.1.5, runner image 20260126.10.1 → 20260209.23.1). These changes get tests passing again and keep multi-platform builds reliable.

Runner version context

Working (tests pass) Breaking (tests failed)
Runner ubuntu-24.04, 20260126.10.1 ubuntu-24.04, 20260209.23.1
Docker Client/Server 28.0.4 29.1.5
Docker-Buildx 0.31.1 0.31.1

Changes (74d0aaa)

  • CI: Add QEMU and Docker Buildx setup for linux/amd64 and linux/arm64.
  • Digest retrieval: Use buildx imagetools first, fall back to docker inspect_image (RepoDigests); raise a clear error if digest cannot be determined after push.
  • Multi-platform result: Use image_ref instead of trunc_digest for the built image so references stay valid with the new Docker/Buildx stack.
  • Post-build: Use legacy builder for the run step post-build so the committed local image is visible (BuildKit in a container cannot see host-only tags).
  • Tests: Add test-systemd and test-ssh-buildx to serial tests; update test-systemd to use docker:27-dind; bump version to 3.21.

Merge requirements satisfied?

  • I have updated the documentation or no documentation changes are required.
  • I have added tests to cover my changes.
  • I have updated the base version in pyproject.toml (if appropriate).

This reverts commit baee0d0, reversing
changes made to cc251e5.
@shanejbrown shanejbrown changed the title Revert "Merge pull request #223 from shanejbrown/XENG-9264" Revert "Merge pull request #223" Feb 12, 2026
Tests began failing after GitHub upgraded the runner environment: Docker
Client/Server moved from 28.0.4 to 29.1.5 (runner image 20260126.10.1 →
20260209.23.1). Buildx stayed at 0.31.1. These changes restore passing
tests and reliable multi-platform builds on the updated runners.

Working (tests pass):
  Image: ubuntu-24.04, Version: 20260126.10.1
  Docker Client/Server: 28.0.4, Docker-Buildx: 0.31.1

Breaking (tests failed):
  Image: ubuntu-24.04, Version: 20260209.23.1
  Docker Client/Server: 29.1.5, Docker-Buildx: 0.31.1

- CI: Add QEMU and Docker Buildx setup for linux/amd64 and linux/arm64.
- Digest retrieval: Prefer buildx imagetools, fall back to docker
  inspect_image (RepoDigests); raise a clear error if digest cannot be
  determined after push.
- Multi-platform result: Use image_ref instead of trunc_digest for the
  built image so references remain valid with the new Docker/Buildx stack.
- Post-build: Use legacy builder for the run step post-build so the
  committed local image is visible to the builder (BuildKit in a
  container cannot see host-only tags).
- Tests: Add test-systemd and test-ssh-buildx to serial tests; update
  test-systemd to use docker:27-dind; bump version to 3.21.
@shanejbrown shanejbrown changed the title Revert "Merge pull request #223" Fix CI and buildx for GitHub Actions Docker 29.x after reverting #223 Feb 18, 2026
@shanejbrown
Copy link
Contributor Author

Passing job with older runner image: https://github.com/adobe/buildrunner/actions/runs/21640676039/attempts/1
Failing job with newer runner image: https://github.com/adobe/buildrunner/actions/runs/21640676039

@shanejbrown shanejbrown merged commit d909509 into adobe:main Feb 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants