Skip to content

feat: no empty version files #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kptdobe wants to merge 3 commits into
base: main
Choose a base branch
from
+309 −47
Draft

feat: no empty version files #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fc3725
feat: get rid of the Collab Parse version
kptdobe Nov 17, 2025
d5cb0e0
feat: no empty version
kptdobe Nov 17, 2025
d44c588
Merge branch 'main' into noempty
kptdobe Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions src/storage/version/put.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,12 +163,9 @@ export async function putObjectWithVersion(
}
}

const pps = current.metadata?.preparsingstore || '0';

// Store the body if preparsingstore is not defined, so a once-off store
let storeBody = !body && pps === '0';
const Preparsingstore = storeBody ? Timestamp : pps;
let Label = storeBody ? 'Collab Parse' : update.label;
const Preparsingstore = current.metadata?.preparsingstore || '0';
let storeBody = false;
let Label = update.label;

if (daCtx.method === 'PUT'
&& daCtx.ext === 'html'
Expand All @@ -183,25 +180,28 @@ export async function putObjectWithVersion(
Label = 'Restore Point';
}

const versionResp = await putVersion(config, {
Bucket: input.Bucket,
Org: daCtx.org,
Body: (body || storeBody ? current.body : ''),
ContentLength: (body || storeBody ? current.contentLength : undefined),
ContentType: current.contentType,
ID,
Version,
Ext: daCtx.ext,
Metadata: {
Users: current.metadata?.users || JSON.stringify([{ email: 'anonymous' }]),
Timestamp: current.metadata?.timestamp || Timestamp,
Path: current.metadata?.path || Path,
Label,
},
});
// Only create version if we have content to store
if (body || storeBody) {
const versionResp = await putVersion(config, {
Bucket: input.Bucket,
Org: daCtx.org,
Body: current.body,
ContentLength: current.contentLength,
ContentType: current.contentType,
ID,
Version,
Ext: daCtx.ext,
Metadata: {
Users: current.metadata?.users || JSON.stringify([{ email: 'anonymous' }]),
Timestamp: current.metadata?.timestamp || Timestamp,
Path: current.metadata?.path || Path,
Label,
},
});

if (versionResp.status !== 200 && versionResp.status !== 412) {
return { status: versionResp.status, metadata: { id: ID } };
if (versionResp.status !== 200 && versionResp.status !== 412) {
return { status: versionResp.status, metadata: { id: ID } };
}
}

// Use client-provided If-Match if available, otherwise use current ETag
Expand Down
Loading
Loading