Skip to content

Conversation

@bosschaert
Copy link
Contributor

Description

Fixes: #88

How Has This Been Tested?

  • Tested locally with da-live and da-collab
  • Add unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bosschaert bosschaert requested a review from karlpauls October 31, 2024 15:26
@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.54%. Comparing base (6d96a9c) to head (5993179).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/object/copy.js 87.50% 6 Missing ⚠️
src/storage/object/move.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   76.42%   77.54%   +1.12%     
==========================================
  Files          37       38       +1     
  Lines        1790     1817      +27     
==========================================
+ Hits         1368     1409      +41     
+ Misses        422      408      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bosschaert
Copy link
Contributor Author

Note that I'm planning to add tests for move.js soon, either in this PR or separately.

@bosschaert bosschaert merged commit 2811b46 into main Dec 4, 2024
3 checks passed
@bosschaert bosschaert deleted the ctr branch December 4, 2024 16:09
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version history behaviors

3 participants