-
Notifications
You must be signed in to change notification settings - Fork 58
Prevent losing colspan on header when adding columns #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
auniverseaway
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small organizational fix, otherwise this is good.
deps/da-y-wrapper/src/index.js
Outdated
|
|
||
| import { InputRule, inputRules } from 'prosemirror-inputrules'; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would follow the existing pattern and not write code directly in this file. The basics seem fine, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored to use a plugin. Overall think it's a reasonably clean approach, but I won't be heart broken if you tell me this works as designed and isn't worth the trouble, as the default behavior does appear to match word
Signed-off-by: Sean Steimer <ssteimer@adobe.com>
…s. Should be a cleaner approach Signed-off-by: Sean Steimer <ssteimer@adobe.com>
Description
wrap
addColumnBeforeandaddColumnAfterto ensure when doing these from block header, header maintains correct col spanRelated Issue
Motivation and Context
just trying to make things easier to use and prevent modifications that don't make sense in context
How Has This Been Tested?
locally at http://localhost:3000/edit#/aem-sandbox/block-collection/drafts/shsteimer/blocks-
new unit tests on table modifications to document/confirm behaviors
Screenshots (if appropriate):
Types of changes
Checklist: