Skip to content

Conversation

@Danialkafeel
Copy link
Contributor

@Danialkafeel Danialkafeel commented Oct 28, 2025

Changes

  • Updated list of cookie consent banner selectors
  • Inclusion of json-ld in content gains analysis and metrics
  • Dynamic loading of version via package.json

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

@github-actions
Copy link

This PR will trigger a patch release when merged.

Copy link
Contributor

@anuj-adobe anuj-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anuj-adobe
Copy link
Contributor

@Danialkafeel build is failing, pls check

@Danialkafeel
Copy link
Contributor Author

@Danialkafeel build is failing, pls check

Due to some npm errors it is failing for other PR/commits too: https://github.com/adobe/spacecat-shared/actions/runs/18901093762/job/53948310028

Will trigger again in some time

Copy link

@jindaliiita jindaliiita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danialkafeel Danialkafeel merged commit 9f993fe into main Oct 29, 2025
7 checks passed
@Danialkafeel Danialkafeel deleted the update-html-analyzer branch October 29, 2025 10:24
solaris007 pushed a commit that referenced this pull request Oct 29, 2025
# [@adobe/spacecat-shared-html-analyzer-v1.0.2](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-html-analyzer-v1.0.1...@adobe/spacecat-shared-html-analyzer-v1.0.2) (2025-10-29)

### Bug Fixes

* json-ld inclusion, cc banner updates ([#1054](#1054)) ([9f993fe](9f993fe))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants