-
Notifications
You must be signed in to change notification settings - Fork 235
docs: improve and clean up contributor docs for barebones merge #5840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
babf636 to
a6acfbd
Compare
a6acfbd to
3e78857
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the removed content here doesn't seem to be in the repo anywhere else anymore, is that intentional? I can see how some things maybe could be removed, but there are other sections (Stackblitz, Requirements, Storybook, Linting) that still seem at least somewhat relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! The content in the original root README.md wasn't supposed to be deleted; it was just supposed to be moved to 1st-gen, and then incrementally migrated from there. I am quite sure I actually did move it, not delete it, but I suspect that it accidentally got lost when I later rebased on an updated barebones. I'll restore it!
Then, as noted in the PR description, the migration and adaptation of content is a WIP; there will be more PRs to follow this one. Technically, what we've done so far is quite a bit beyond the requirements we established for the Barebones milestone, so finishing the migration of the remaining content isn't a blocker for merging to main—but I am nonetheless trying to get more of it migrated in that timeframe, just on principle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I just added a note to the top of this PR description to clarify the scope of this PR within the larger arc of contributor-doc improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes. I have a larger concern about making sure these documents stay up-to-date and accessible, especially those related to workstreams and status. We definitely need a plan or checklist to deal with updating those frequently. Curious about others' thoughts there.
CONTRIBUTOR-DOCS/01_contributor-guides/02_using-the-issue-tracker.md
Outdated
Show resolved
Hide resolved
CONTRIBUTOR-DOCS/01_contributor-guides/02_using-the-issue-tracker.md
Outdated
Show resolved
Hide resolved
CONTRIBUTOR-DOCS/01_contributor-guides/04_making-a-pull-request.md
Outdated
Show resolved
Hide resolved
CONTRIBUTOR-DOCS/01_contributor-guides/04_making-a-pull-request.md
Outdated
Show resolved
Hide resolved
CONTRIBUTOR-DOCS/01_contributor-guides/04_making-a-pull-request.md
Outdated
Show resolved
Hide resolved
| - `breaking-change`: PR contains changes that break backward compatibility | ||
| - `Component: [Name]`: PR affects this component | ||
|
|
||
| For a complete list of labels and their meanings, including reviewer-specific labels, see [Participating in PR reviews](05_participating-in-pr-reviews.md#labels-and-their-meanings). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of don't want to have this live in a markdown file--I'd rather link to our github labels directly just because it's a lot of overhead to maintain.
CONTRIBUTOR-DOCS/01_contributor-guides/05_participating-in-pr-reviews.md
Outdated
Show resolved
Hide resolved
CONTRIBUTOR-DOCS/01_contributor-guides/05_participating-in-pr-reviews.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Najika Halsema Yoo <44980010+najikahalsema@users.noreply.github.com>
Co-authored-by: Najika Halsema Yoo <44980010+najikahalsema@users.noreply.github.com>
Co-authored-by: Najika Halsema Yoo <44980010+najikahalsema@users.noreply.github.com>
191c51a to
11e7cc6
Compare
@najikahalsema I hear you, but the theory here is that these documents are the place where we establish our plans, not just a place where we document them for others—so as long as we actually get out in front of planning, we shouldn't run into an issue with staleness here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just had one minor formatting thing I noticed that shouldn't require re-review from me.
CONTRIBUTOR-DOCS/01_contributor-guides/04_making-a-pull-request.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Najika Halsema Yoo <44980010+najikahalsema@users.noreply.github.com>
Description
This PR restructures the contributor documentation to prioritize day-to-day contributor needs and migrates essential guides from 1st-gen documentation, adapting them to reflect the current project structure.
What changed
New contributor guides (migrated and adapted from 1st-gen docs)
Improved documentation structure
Root-level improvements
CONTRIBUTING.mdand streamlinedREADME.mdto provide quick-start information with links to detailed guidesWhat's next
This migration is ongoing. Future PRs will continue moving and adapting content from 1st-gen documentation to ensure all contributor-facing information is accessible at the repository root.
Motivation and context
This reorganization makes it easier for contributors to: