Skip to content

Conversation

@nikkimk
Copy link
Contributor

@nikkimk nikkimk commented Dec 9, 2025

Description

Fixed asset story to render image in playground story's default slot.

Motivation and context

We can see how the updated docs and stories would look in our storybook implementation.

Related issue(s)

  • N/A

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

⚠️ No Changeset found

Latest commit: a56397a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nikkimk nikkimk changed the base branch from main to garage-week/docs-rocks December 9, 2025 14:29
@nikkimk nikkimk marked this pull request as ready for review December 9, 2025 14:29
@nikkimk nikkimk requested a review from a team as a code owner December 9, 2025 14:29
@nikkimk nikkimk changed the title docs(asset): foxed asset story docs(asset): fixed asset story Dec 9, 2025
@nikkimk nikkimk requested a review from caseyisonit December 9, 2025 14:30
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5926

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@caseyisonit caseyisonit merged commit 0905bbd into garage-week/docs-rocks Dec 9, 2025
21 checks passed
@caseyisonit caseyisonit deleted the nikkimk/docs-rox-html branch December 9, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants