-
Notifications
You must be signed in to change notification settings - Fork 565
Numen ai #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Numen ai #41
Changes from all commits
2fb2ef2
196c4fb
ca01be4
54e1398
2638fb1
d9d96dc
8c69c62
f6d862d
ea9bef4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,7 +10,7 @@ const Collaboration = () => { | |||||||
| <div className="container lg:flex"> | ||||||||
| <div className="max-w-[25rem]"> | ||||||||
| <h2 className="h2 mb-4 md:mb-8"> | ||||||||
| AI Chat App for seamless collaboration | ||||||||
| Smart Math Education Platform for seamless collaboration | ||||||||
| </h2> | ||||||||
|
|
||||||||
| <ul className="max-w-[22rem] mb-10 md:mb-14"> | ||||||||
|
|
@@ -27,7 +27,7 @@ const Collaboration = () => { | |||||||
| ))} | ||||||||
| </ul> | ||||||||
|
|
||||||||
| <Button>Try it now</Button> | ||||||||
| <a href="https://docs.google.com/forms/d/e/1FAIpQLSet6U4qZXxAbDgBUh95HQkbciYa8g-LyIJMhjxBq0Ub4NMidQ/viewform?usp=header" target="_blank"><Button>Try it now</Button></a> | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Remove redundant anchor tag wrapper. The Button component already handles the - <a href="https://docs.google.com/forms/d/e/1FAIpQLSet6U4qZXxAbDgBUh95HQkbciYa8g-LyIJMhjxBq0Ub4NMidQ/viewform?usp=header" target="_blank"><Button>Try it now</Button></a>
+ <Button href="https://docs.google.com/forms/d/e/1FAIpQLSet6U4qZXxAbDgBUh95HQkbciYa8g-LyIJMhjxBq0Ub4NMidQ/viewform?usp=header">Try it now</Button>Note: You may need to update the Button component to handle the 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||
| </div> | ||||||||
|
|
||||||||
| <div className="lg:ml-auto xl:w-[38rem] mt-4"> | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify that video query parameters work with your bundler.
The query parameters
?autoplay&loop&mutedon the video import may not be processed correctly by all bundlers. Most bundlers treat query parameters on imports differently than HTML video attributes.Consider configuring these video properties in the component that uses this asset instead of in the import statement.
🏁 Script executed:
Length of output: 70
🏁 Script executed:
Length of output: 4353
🏁 Script executed:
Length of output: 704
Configure video attributes on the
<video>element instead of using import query parametersThe current import
does not translate into HTML attributes on the
<video>tag. Browsers ignore URL query parameters for autoplay, loop, and muted—these must be set as element attributes.Please update:
<video ref={videoRef} src={robot} + autoplay + loop + muted + playsInline className="w-full h-full … object-cover" width={1024} height={490} />This ensures the video will autoplay (muted), loop, and honor mobile inline playback.
🤖 Prompt for AI Agents