Make the context menu readable

[moonglum]

While working on my other PR (no, I have not forgotten about it 😃), I noticed a bug in Textfox. In the default configuration, you can't read the hovered text in context menus (the item below "Save Page as..." is hovered):

This is due to menu using --tab-selected-bgcolor and menuitem using --tab-hover-background-color. When reverting this, they are readable:

[adriankarlen]

Hmm for me it works as expected, probably not related to the actual usage of the variable but rather the variable override.

[moonglum]

I'm not 100% sure I understand the selectors. The first one is for the ones that are not disabled, and the second one is for ones that are active and disabled?

  &:where([_moz-menuactive]:not([disabled="true"])) {
    background: var(--tab-selected-bgcolor) !important;
  }
  &:where([_moz-menuactive="true"][disabled="true"]) {
    background: var(--tab-hover-background-color) !important;
  }

Looking into the colors, they are defined in overwrites.css. Both are color mixes of --toolbar-field-color and --toolbar-bgcolor. But I don't see that they are changed anywhere in the codebase.

[adriankarlen]

Are you using Firefox Color extension?

I think the css variables are from that extension. It is the recommended way to theme textfox. Instead of removing code a fallback to the default should be added to the variable.