Skip to content

Conversation

@ehenneken
Copy link
Member

Implementation of issue #284

When a record has doctype techreport the BibTeX type @TECHREPORT will only get assigned when the publisher field is populated. This PR also updated the fields used for @TECHREPORT. Appropriate unittests have been implement to test this behavior.

@coveralls
Copy link

coveralls commented Aug 22, 2025

Coverage Status

coverage: 96.57% (-0.06%) from 96.63%
when pulling b0bdca6 on ehenneken:bibtex_techreport
into 95629fe on adsabs:master.

Copy link
Member

@kelockhart kelockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor thing about the code comments, but otherwise looks good to me!

@@ -177,12 +185,11 @@ def __get_fields(self, a_doc):
('aff', 'school'), ('year', 'year'), ('month', 'month'),
('bibcode', 'adsurl'),('adsnotes', 'adsnote')]
# 2/14 mapping techreport and intechreport to @MISC per Markus request for now
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this comment, since you've superseded it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@ehenneken ehenneken merged commit 99ed9b8 into adsabs:master Aug 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants