Skip to content

Conversation

@thostetler
Copy link
Member

@thostetler thostetler commented Feb 9, 2026

Full text sources previously relied on icon color alone (green vs gray)
to indicate access level, making it difficult to scan at a glance.

  • Add "Available" / "Login required" pill badges next to each source group name in accordion view
  • Add per-item access tags in the dropdown menu view
  • Extract access label derivation into accessLabel.ts helper
  • Normalize institution icon sizing and style it as subtle dark gray
  • Add unit and integration tests for access label logic and badge rendering
image image

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 88.61789% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.4%. Comparing base (161f125) to head (f5a6348).

Files with missing lines Patch % Lines
...components/AbstractSources/AbstractSourceItems.tsx 85.2% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #794     +/-   ##
========================================
+ Coverage    61.3%   61.4%   +0.1%     
========================================
  Files         307     308      +1     
  Lines       35535   35609     +74     
  Branches     1553    1564     +11     
========================================
+ Hits        21762   21836     +74     
+ Misses      13737   13736      -1     
- Partials       36      37      +1     
Files with missing lines Coverage Δ
src/components/AbstractSources/accessLabel.ts 100.0% <100.0%> (ø)
...components/AbstractSources/AbstractSourceItems.tsx 82.9% <85.2%> (+3.1%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…sources

Show "Available" (green) or "Login required" (yellow) pill badges next
to each source group name in accordion view, and per-item tags in menu
view. Institution links are excluded from access labeling.

- Extract access label logic into accessLabel.ts helper
- Add group-level Badge in accordion, per-item Tag in menu
- Normalize AcademicCapIcon size to match PDF/HTML icons (24x24)
- Style institution icon as subtle dark gray
- Suppress redundant "INSTITUTION" type label from institution links
- Add unit tests for access label helpers
- Add integration tests for badge rendering in both views
@thostetler
Copy link
Member Author

@shinyichen this was in response to a user mentioning that one the desktop view of the site we don't have a clear indication of OPEN_ACCESS links. which is true, in ADS we have text in the popover, but in scix we're only indicating this via color.

Anyway, I thought this was a little better design, but would like some feedback!

@thostetler thostetler marked this pull request as ready for review February 9, 2026 18:14
@thostetler thostetler merged commit bed1021 into adsabs:master Feb 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants