Skip to content

Conversation

@thostetler
Copy link
Member

@thostetler thostetler commented Feb 10, 2026

Feedback dropdown menu items used router.push() via onClick handlers,
which meant users could not Cmd+Click or right-click to open feedback
forms in a new tab. This forced users to lose their search results view
when navigating to feedback forms -- a problem when they need to
reference bibcodes from their results while filling out the form.

  • Replaced MenuDropdown abstraction in FeedbackDropdown with direct Menu rendering using MenuItem as="a" with href attributes
  • Feedback menu items now support Cmd+Click, Ctrl+Click, and right-click "Open in new tab"
  • Regular click still navigates in same tab (unchanged UX for users who don't need new tab)
  • Preserves the from query parameter for return navigation
  • Fixed pre-existing bug where trailing ?/& chars were left in the from param after stripping
  • Added tests
image

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.6%. Comparing base (908d3ec) to head (5975573).

Files with missing lines Patch % Lines
src/components/NavBar/FeedbackDropdown.tsx 96.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #798     +/-   ##
========================================
+ Coverage    61.6%   61.6%   +0.1%     
========================================
  Files         312     313      +1     
  Lines       35995   36087     +92     
  Branches     1593    1598      +5     
========================================
+ Hits        22141   22228     +87     
- Misses      13817   13822      +5     
  Partials       37      37             
Files with missing lines Coverage Δ
src/components/NavBar/FeedbackDropdown.tsx 96.8% <96.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant