Skip to content

fix: skip flaky observer shell test on Windows#722

Merged
affaan-m merged 1 commit intomainfrom
fix/flaky-observer-windows
Mar 20, 2026
Merged

fix: skip flaky observer shell test on Windows#722
affaan-m merged 1 commit intomainfrom
fix/flaky-observer-windows

Conversation

@affaan-m
Copy link
Owner

@affaan-m affaan-m commented Mar 20, 2026

Skips the observer-memory bash test on Windows where it's unreliable. Fixes the remaining 2 Windows CI failures on main.


Summary by cubic

Skip the shell-based observe.sh E2E test on Windows where it's flaky to stabilize CI and clear the last two Windows failures on main.

Written for commit d810e34. Summary will update on new commits.

Summary by CodeRabbit

  • Tests
    • Added Windows compatibility check to an observer test, ensuring proper test execution across platforms.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

affaan-m has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1a61fe7e-727a-455b-be18-3f74db9d699e

📥 Commits

Reviewing files that changed from the base of the PR and between 2643e0c and d810e34.

📒 Files selected for processing (1)
  • tests/hooks/observer-memory.test.js

📝 Walkthrough

Walkthrough

A platform-specific guard was added to a test in the observer hooks module to skip the observe.sh counter-file test on Windows systems by immediately returning when process.platform === 'win32'.

Changes

Cohort / File(s) Summary
Windows Platform Guard
tests/hooks/observer-memory.test.js
Added early return condition to skip shell-based test execution on Windows platform.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A guard was placed with careful thought,
To skip the shell on Windows brought,
Now tests will dance where platforms allow,
The rabbit hops and takes a bow! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a Windows platform guard to skip a flaky observer shell test on Windows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/flaky-observer-windows
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d810e3414b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +219 to +221
if (process.platform === 'win32') {
return;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep Windows coverage for the observe.sh counter path

On Windows runners with Git Bash, this skips the only end-to-end assertion that observe.sh actually creates and updates .observer-signal-counter. That matters because the shipped hook config still invokes skills/continuous-learning-v2/hooks/observe.sh via bash ... run-with-flags-shell.sh for both pre/post events (hooks/hooks.json:70, hooks/hooks.json:215), and hooks/README.md:213 says those shell wrappers have Windows-safe fallback behavior. With this guard in place, a Windows-only regression in the counter-file logic or path handling will no longer be caught by CI.

Useful? React with 👍 / 👎.

@affaan-m affaan-m merged commit 7ccfda9 into main Mar 20, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant