fix: skip flaky observer shell test on Windows#722
Conversation
There was a problem hiding this comment.
affaan-m has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA platform-specific guard was added to a test in the observer hooks module to skip the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d810e3414b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (process.platform === 'win32') { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Keep Windows coverage for the observe.sh counter path
On Windows runners with Git Bash, this skips the only end-to-end assertion that observe.sh actually creates and updates .observer-signal-counter. That matters because the shipped hook config still invokes skills/continuous-learning-v2/hooks/observe.sh via bash ... run-with-flags-shell.sh for both pre/post events (hooks/hooks.json:70, hooks/hooks.json:215), and hooks/README.md:213 says those shell wrappers have Windows-safe fallback behavior. With this guard in place, a Windows-only regression in the counter-file logic or path handling will no longer be caught by CI.
Useful? React with 👍 / 👎.
Skips the observer-memory bash test on Windows where it's unreliable. Fixes the remaining 2 Windows CI failures on main.
Summary by cubic
Skip the shell-based
observe.shE2E test on Windows where it's flaky to stabilize CI and clear the last two Windows failures onmain.Written for commit d810e34. Summary will update on new commits.
Summary by CodeRabbit