Skip to content

fix(ui): improve edit control ux, no layout shift, consistent spacing#122

Open
adelindanaila wants to merge 2 commits intomainfrom
fix/ui-improve-edit-control-ux
Open

fix(ui): improve edit control ux, no layout shift, consistent spacing#122
adelindanaila wants to merge 2 commits intomainfrom
fix/ui-improve-edit-control-ux

Conversation

@adelindanaila
Copy link
Collaborator

Summary

  • ensured consistent spacing, prevent layout shift, basic theme.ts config

Scope

  • User-facing/API changes: Edit/Add Control modal only: improved spacing and no layout shift when toggling Form/JSON or when validation state appears.
  • Internal changes: New ui/src/theme.ts with default form-input label styles;
  • Out of scope:

Risk and Rollout

  • Risk level: low
  • Rollback plan: revert

Testing

  • Added or updated automated tests
  • Ran make check (or explained why not)
  • Manually verified behavior

Checklist

  • Linked issue/spec (if applicable)
  • Updated docs/examples for user-facing changes
  • Included any required follow-up tasks

@adelindanaila adelindanaila force-pushed the fix/ui-improve-edit-control-ux branch from ec0ac18 to 7eee222 Compare March 12, 2026 22:14
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@siddhant-galileo
Copy link
Collaborator

hey @adelindanaila , can you pls attach screenshot to highlight the changes made. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants