Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENT_CONTROL_DB_URLso the bundled server uses the matching credential by default.AGENT_CONTROL_POSTGRES_PASSWORDand document it in the root quickstart README.Scope
docker-compose.ymlnow supportsAGENT_CONTROL_POSTGRES_PASSWORDfor the bundled Postgres + server setup.README.mdquickstart now shows how to override the bundled PostgreSQL password.docker-compose.dev.ymlor direct server env var handling outside the bundled compose path.Risk and Rollout
Testing
make check(or explained why not)Manual verification performed:
docker compose -f docker-compose.yml configto verify the compose file renders correctly after the env var and quoting changes.Why automated checks were not run:
Checklist
Follow-up notes:
AGENT_CONTROL_POSTGRES_PASSWORDdoes not retroactively rotate the database password inside an already-initialized volume.