fix(examples): shut down SDK in short-lived demos#85
Merged
abhinav-galileo merged 4 commits intomainfrom Mar 12, 2026
Merged
Conversation
abhinav-galileo
requested review from
lan17,
namrataghadi-galileo and
siddhant-galileo
and removed request for
namrataghadi-galileo
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
lan17
requested changes
Mar 10, 2026
Contributor
|
Tested all examples and they worked. |
abhinav-galileo
force-pushed
the
abhi/examples-shutdown-updates
branch
from
9a4ee63 to
67863a4
Compare
lan17
approved these changes
Mar 11, 2026
Contributor
lan17
left a comment
lan17
left a comment
There was a problem hiding this comment.
please consider not wrapping large chunks of code in try/finally. a more readable approach is to wrap try/finally around a single function call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated docs/examples for user-facing changes