ci(agentfront-frontmcp): add HOL skill-publish validate workflow#345
ci(agentfront-frontmcp): add HOL skill-publish validate workflow#345internet-dot wants to merge 1 commit intoagentfront:mainfrom
Conversation
📝 WalkthroughWalkthroughA new GitHub Actions workflow file is introduced to validate HOL skills on push and pull request events targeting main and master branches. The workflow runs a single validation job using the hashgraph-online/skill-publish action with appropriate repository access permissions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/hol-skill-validate.yml:
- Around line 14-16: The workflow grants unnecessary id-token write permission
and relies on preview uploads; remove the id-token: write permission from the
permissions block and explicitly set the skill-publish action to validate-only
by adding with: mode: validate and preview-upload: "false" (and annotate:
"false" if desired) in the Validate Skill step so OIDC is not required and
least-privilege is maintained.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4cf760d6-0460-4088-8d92-873627da2136
📒 Files selected for processing (1)
.github/workflows/hol-skill-validate.yml
| permissions: | ||
| contents: read | ||
| id-token: write |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Does hashgraph-online/skill-publishrequirepermissions: id-token: writewhenwith.modeis set tovalidate? Please provide the action documentation and minimum required GitHub Actions permissions for validate-only usage.
💡 Result:
No—hashgraph-online/skill-publish does not require permissions: id-token: write for with.mode: validate as long as you disable preview uploads (preview-upload: "false"). The README’s “validate-only pull request workflow” explicitly says it “does not request id-token: write” and shows permissions: contents: read with preview-upload: "false". [1]
However, the action input preview-upload is described as uploading validate/monitor previews “through GitHub OIDC when available” (and its default is "true"), which is the scenario where you’d typically need id-token: write. [2]
Validate-only (minimum permissions)
Minimum required GitHub Actions permissions (validate-only, no preview upload, no annotations):
permissions:
contents: readThis is the exact tightened permission set the README calls out as sufficient when annotations are disabled. [1]
Recommended validate-only usage (from the README):
- uses: hashgraph-online/skill-publish@v1
with:
mode: validate
skill-dir: skills/my-skill
annotate: "false"
preview-upload: "false"[1]
When would id-token: write be needed in validate mode?
Only if you opt into preview uploads (i.e., preview-upload: "true"), because the action documents that this upload is done via GitHub OIDC. [2] The README recommends enabling this only in trusted (repo-owned) workflows and then adding id-token: write. [1]
Sources
hashgraph-online/skill-publishREADME (validate-first quickstart; permissions guidance). [1]hashgraph-online/skill-publishaction.yml(inputs, includingpreview-uploadand OIDC description/default). [2]
🏁 Script executed:
cat -n .github/workflows/hol-skill-validate.ymlRepository: agentfront/frontmcp
Length of output: 773
Remove id-token: write and configure validate-only mode explicitly.
This workflow defaults to preview-upload: "true", which uses GitHub OIDC and requires id-token: write. For a true validate-only workflow, disable preview uploads and remove the unnecessary permission to follow least-privilege:
permissions:
contents: read
jobs:
validate:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5
- name: Validate Skill
uses: hashgraph-online/skill-publish@1c30734416d9b05948ccd7f4b3cf60baada87e9e
with:
mode: validate
preview-upload: "false"
annotate: "false"Keep id-token: write only if preview uploads are intentionally enabled.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/hol-skill-validate.yml around lines 14 - 16, The workflow
grants unnecessary id-token write permission and relies on preview uploads;
remove the id-token: write permission from the permissions block and explicitly
set the skill-publish action to validate-only by adding with: mode: validate and
preview-upload: "false" (and annotate: "false" if desired) in the Validate Skill
step so OIDC is not required and least-privilege is maintained.
|
Heads up @frontegg-david -- this PR is part of a mass-submission campaign by Several repos have already merged it. Full write-up with details here: TickTockBent/charlotte#143 (comment) Recommend closing without merging. |
@TickTockBent Thanks a lot for the heads up and for taking the time to dig into this 🙏 Really appreciate you flagging it so quickly and sharing the details — we’ll close this PR and make sure nothing like this gets merged. |
Adding a validate-only skill metadata workflow to catch schema issues early.
This PR adds one workflow file under
.github/workflows/that runs the HOL skill validator in validate mode. It checks schema and trust signals, stays validate-only, and doesn't touch runtime code.Let me know if you'd prefer a different workflow filename or skill directory path — happy to adjust.
Summary by CodeRabbit