Fix crash MacOS because of multiprocessing fork#133
Open
raryelcostasouza wants to merge 5 commits intoagermanidis:masterfrom
Open
Fix crash MacOS because of multiprocessing fork#133raryelcostasouza wants to merge 5 commits intoagermanidis:masterfrom
raryelcostasouza wants to merge 5 commits intoagermanidis:masterfrom
Conversation
Contributor
Author
|
The automatic build checker failed because it uses python 2.7 as default, and python 2 doesn't have the set_start_method. My patch fix the problem for python 3, but for python 2 it would need a bigger workaround (as reported at https://bugs.python.org/issue33725). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running on MacOS High Sierra, soon after starting the multiprocessing.pool it was crashing completely with error below:
According to documentation of multiprocessing: https://docs.python.org/3.4/library/multiprocessing.html
The default unix fork is not safe for threads... and MacOS doesn't seem to like that... crashing completely.