Draft
Conversation
…some Cargo.toml files
Contributor
Author
|
Finishing this will require getting real EVMStateSketches and not trying to build them manually in the test runs. We should already have some in the checked-in bridge constraints input json. Message from @hadjiszs:
For now, I'm pausing this work, due to more pressing things being under way |
Contributor
Author
|
Unassigning myself for now, as I have too much other pressing assigned stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my WIP on reenabling the aggkit-prover tests #74. It builds on top of #192.
Fixes #74
Currently failing with:
The error seems to come from this line:
https://github.com/succinctlabs/sp1-contract-call/blob/4752cebf7784f5ac78117a0e004275c6f53f0af4/crates/client-executor/src/lib.rs#L143
Unfortunately it seems to me like I'll need to actually run an anvil in order to get two EVMStateSketches; as this is the only reason I could guess for it to be wrong. Or maybe I could dump some real-world EVMStateSketches as JSON and load them from there…
PR Checklist: