Skip to content

test: reenable aggkit-prover tests#195

Draft
Ekleog-Polygon wants to merge 9 commits intomainfrom
ekleog/reenable-tests
Draft

test: reenable aggkit-prover tests#195
Ekleog-Polygon wants to merge 9 commits intomainfrom
ekleog/reenable-tests

Conversation

@Ekleog-Polygon
Copy link
Contributor

@Ekleog-Polygon Ekleog-Polygon commented Apr 30, 2025

Here is my WIP on reenabling the aggkit-prover tests #74. It builds on top of #192.

Fixes #74

Currently failing with:

stderr: 
stderr: thread '<unnamed>' panicked at src/main.rs:9:82:
stderr: called `Result::unwrap()` on an `Err` value: BridgeConstraintsError(StaticCallError { stage: PrevHashChain(InsertedGER), source: ClientExecution(transaction validation error: caller gas limit exceeds the block gas limit
stderr: 
stderr: Caused by:
stderr:     caller gas limit exceeds the block gas limit
stderr: 
stderr: Location:
stderr:     sp1-contract-call-a2505982cc25224e/83ca051/crates/client-executor/src/lib.rs:143:25) })
stderr: stack backtrace:
stderr: note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stderr: called `Result::unwrap()` on an `Err` value: BridgeConstraintsError(StaticCallError { stage: PrevHashChain(InsertedGER), source: ClientExecution(transaction validation error: caller gas limit exceeds the block gas limit
stderr: 
stderr: Caused by:
stderr:     caller gas limit exceeds the block gas limit
stderr: 
stderr: Location:

thread 'tests::service_can_be_called' panicked at crates/aggkit-prover/src/tests/mod.rs:222:33:
called `Result::unwrap()` on an `Err` value: AggchainProofBuilderRequestFailed(ProverFailedToExecute(Prover failed: execution failed with exit code 1))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The error seems to come from this line:
https://github.com/succinctlabs/sp1-contract-call/blob/4752cebf7784f5ac78117a0e004275c6f53f0af4/crates/client-executor/src/lib.rs#L143

Unfortunately it seems to me like I'll need to actually run an anvil in order to get two EVMStateSketches; as this is the only reason I could guess for it to be wrong. Or maybe I could dump some real-world EVMStateSketches as JSON and load them from there…

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Ekleog-Polygon Ekleog-Polygon changed the title Ekleog/reenable tests test: reenable aggkit-prover tests Apr 30, 2025
@Ekleog-Polygon Ekleog-Polygon self-assigned this May 14, 2025
@Ekleog-Polygon
Copy link
Contributor Author

Finishing this will require getting real EVMStateSketches and not trying to build them manually in the test runs. We should already have some in the checked-in bridge constraints input json.

Message from @hadjiszs:

We actually have already real dumps of such sketches in one json committed in the repository crates/aggchain-proof-core/src/test_input/bridge_constraints_input.json
used by this test

For now, I'm pausing this work, due to more pressing things being under way

@Ekleog-Polygon
Copy link
Contributor Author

Unassigning myself for now, as I have too much other pressing assigned stuff

@Ekleog-Polygon Ekleog-Polygon removed their assignment Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable the tests already present in the aggkit-prover crate

3 participants