Open
Conversation
Ekleog-Polygon
approved these changes
Jun 5, 2025
Contributor
Ekleog-Polygon
left a comment
There was a problem hiding this comment.
LGTM, thank you! Unfortunately we are still waiting for legal approval before landing external contributors' PRs, but the changes here are technically ready to merge 😄
Contributor
|
Oh, just one thing: to get CI to pass you'll need to adjust your commits and PR title to eg. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request corrects a typo in the log message within the
crates/proposer-client/src/rpc/mod.rsfile. The word "fullfilled" has been changed to the correct spelling "fulfilled" in the info log statement for mock proof requests. No functional changes were made; this is a minor improvement for clarity and professionalism in log output.