Skip to content

refactor(prover-alloy): extract common client builder logic #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aso20455 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(prover-alloy): extract common client builder logic #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions crates/prover-alloy/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ pub type AlloyFillProvider = FillProvider<
Ethereum,
>;

pub fn build_alloy_fill_provider(
/// Creates a client builder with common configuration for HTTP RPC clients
fn create_client_builder(
rpc_url: &url::Url,
backoff: u64,
max_retries: u32,
) -> Result<AlloyFillProvider, anyhow::Error> {
) -> Result<ClientBuilder, anyhow::Error> {
let retry_policy = RetryBackoffLayer::new(max_retries, backoff, 5);
let reqwest_client = reqwest::ClientBuilder::new()
.pool_max_idle_per_host(HTTP_CLIENT_MAX_IDLE_CONNECTIONS_PER_HOST)
Expand All @@ -45,10 +46,17 @@ pub fn build_alloy_fill_provider(

let http = alloy::transports::http::Http::with_client(reqwest_client, rpc_url.clone());
let is_local = http.guess_local();
let client = ClientBuilder::default()
Ok(ClientBuilder::default()
.layer(retry_policy)
.transport(http, is_local);
.transport(http, is_local))
}

pub fn build_alloy_fill_provider(
rpc_url: &url::Url,
backoff: u64,
max_retries: u32,
) -> Result<AlloyFillProvider, anyhow::Error> {
let client = create_client_builder(rpc_url, backoff, max_retries)?;
Ok(ProviderBuilder::new().on_client(client))
}

Expand All @@ -65,20 +73,7 @@ impl AlloyProvider {
backoff: u64,
max_retries: u32,
) -> Result<AlloyProvider, anyhow::Error> {
let retry_policy = RetryBackoffLayer::new(max_retries, backoff, 5);
let reqwest_client = reqwest::ClientBuilder::new()
.pool_max_idle_per_host(HTTP_CLIENT_MAX_IDLE_CONNECTIONS_PER_HOST)
.pool_idle_timeout(Duration::from_secs(
HTTP_CLIENT_CONNECTION_POOL_IDLE_TIMEOUT,
))
.build()?;

let http = alloy::transports::http::Http::with_client(reqwest_client, rpc_url.clone());
let is_local = http.guess_local();
let client = ClientBuilder::default()
.layer(retry_policy)
.transport(http, is_local);

let client = create_client_builder(rpc_url, backoff, max_retries)?;
Ok(AlloyProvider {
client: ProviderBuilder::new().on_client(client),
})
Expand Down