Skip to content

P1 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
agileup wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

P1 #17

agileup wants to merge 2 commits into from

Conversation

@agileup
Copy link
Owner

@agileup agileup commented Jan 26, 2016

P1-2

agileup and others added 2 commits December 16, 2015 09:45
@agileup
Copy link
Owner Author

agileup commented Jan 26, 2016

P1-3

agileup
agileup reviewed Jan 26, 2016
View reviewed changes
EVENTS.md
Copy link
Owner Author

@agileup agileup Jan 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRC1

@agileup
Copy link
Owner Author

agileup commented Jan 26, 2016

P1-4

@agileup
Copy link
Owner Author

agileup commented Jan 26, 2016

P1-5

@agileup
Copy link
Owner Author

agileup commented Jan 26, 2016

P1-6

@agileup
Copy link
Owner Author

agileup commented Jan 26, 2016

P1-7

agileup
agileup reviewed Jan 26, 2016
View reviewed changes
README.md
Copy link
Owner Author

@agileup agileup Jan 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRC2

Copy link
Collaborator

@eiryklav84 eiryklav84 Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜리뷰1

Copy link
Collaborator

@eiryklav84 eiryklav84 Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요청 코멘트2

Copy link
Collaborator

@eiryklav84 eiryklav84 Jul 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test - 1

@agileup
Copy link
Owner Author

agileup commented Jan 26, 2016

P1-8

@agileup agileup requested a review from eiryklav84 April 4, 2017 08:09
@agileup
Copy link
Owner Author

agileup commented Apr 4, 2017

CCCCC

eiryklav84
eiryklav84 reviewed Apr 4, 2017
View reviewed changes
README.md
1. 인증을 통해 access_token 획득
2. 해당 토큰으로 특정 repository에 webhook 생성
3. webhook callback api server 개발
4. payload 데이터 가공
Copy link
Collaborator

@eiryklav84 eiryklav84 Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰#1

Copy link
Collaborator

@eiryklav84 eiryklav84 Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인 코멘트1

eiryklav84
eiryklav84 reviewed Apr 4, 2017
View reviewed changes
README.md
1. 인증을 통해 access_token 획득
2. 해당 토큰으로 특정 repository에 webhook 생성
3. webhook callback api server 개발
4. payload 데이터 가공
Copy link
Collaborator

@eiryklav84 eiryklav84 Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가 싱글 코멘트1

Copy link
Collaborator

@eiryklav84 eiryklav84 Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요청 코멘트1

eiryklav84
eiryklav84 reviewed Apr 4, 2017
View reviewed changes
Copy link
Collaborator

@eiryklav84 eiryklav84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜리뷰 써머리(Comment)

EVENTS.md
@@ -0,0 +1,6 @@
# 웹훅 이벤트 종류
- push
Copy link
Collaborator

@eiryklav84 eiryklav84 Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜리뷰2

EVENTS.md
- push
- commit_comment
- create
- delete
Copy link
Collaborator

@eiryklav84 eiryklav84 Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜리뷰3

eiryklav84
eiryklav84 requested changes Apr 4, 2017
View reviewed changes
Copy link
Collaborator

@eiryklav84 eiryklav84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요청 코멘트 써머리(Request changes)

README.md
1. 인증을 통해 access_token 획득
2. 해당 토큰으로 특정 repository에 webhook 생성
3. webhook callback api server 개발
4. payload 데이터 가공
Copy link
Collaborator

@eiryklav84 eiryklav84 Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요청 코멘트1

eiryklav84
eiryklav84 approved these changes Apr 4, 2017
View reviewed changes
Copy link
Collaborator

@eiryklav84 eiryklav84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인 코멘트 써머리(Approve)

README.md
1. 인증을 통해 access_token 획득
2. 해당 토큰으로 특정 repository에 webhook 생성
3. webhook callback api server 개발
4. payload 데이터 가공
Copy link
Collaborator

@eiryklav84 eiryklav84 Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인 코멘트1

eiryklav84
eiryklav84 approved these changes Jul 10, 2017
View reviewed changes
Copy link
Collaborator

@eiryklav84 eiryklav84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary - 1

eiryklav84
eiryklav84 previously requested changes Jul 10, 2017
View reviewed changes
Copy link
Collaborator

@eiryklav84 eiryklav84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1234

@eiryklav84 eiryklav84 dismissed their stale review July 10, 2017 08:28

dismiss test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eiryklav84 eiryklav84 eiryklav84 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agileup @eiryklav84